From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936094AbdLRT1e (ORCPT ); Mon, 18 Dec 2017 14:27:34 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:34205 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934493AbdLRT1c (ORCPT ); Mon, 18 Dec 2017 14:27:32 -0500 X-Google-Smtp-Source: ACJfBoucjhZ8DD/VIzxfErFElJmDPBc3xoj5vIm29oApzCFYIdgSARSEi9ktAbkqmapl6Y/HH1o6dQ== Message-ID: <1513625246.3434.0.camel@gmail.com> Subject: Re: [PATCH] Staging: irda: Do not check for NOT NULL before kfree() From: Shreeya Patel To: Stephen Hemminger Cc: samuel@sortiz.org, gregkh@linuxfoundation.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 19 Dec 2017 00:57:26 +0530 In-Reply-To: <20171218112038.15626e20@xeon-e3> References: <1513624290-2965-1-git-send-email-shreeya.patel23498@gmail.com> <20171218112038.15626e20@xeon-e3> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-12-18 at 11:20 -0800, Stephen Hemminger wrote: > On Tue, 19 Dec 2017 00:41:30 +0530 > Shreeya Patel wrote: > > > > > Do not check for NOT NULL before calling kfree because if the > > pointer is NULL, no action occurs. > > Done using the following semantic patch by coccinelle. > > > > @@ > > expression ptr; > > @@ > > > > - if (ptr != NULL) { > >   kfree(ptr); > >   ptr = NULL; > > - } > > > > The semantic patch has the effect of adding an assignment > > of ptr to NULL in the case where ptr is NULL already. > > > > Signed-off-by: Shreeya Patel > Please read drivers/staging/irda/TODO Oh, I was not knowing about it. Thank you > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreeya Patel Subject: Re: [PATCH] Staging: irda: Do not check for NOT NULL before kfree() Date: Tue, 19 Dec 2017 00:57:26 +0530 Message-ID: <1513625246.3434.0.camel@gmail.com> References: <1513624290-2965-1-git-send-email-shreeya.patel23498@gmail.com> <20171218112038.15626e20@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, samuel@sortiz.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Stephen Hemminger Return-path: In-Reply-To: <20171218112038.15626e20@xeon-e3> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org T24gTW9uLCAyMDE3LTEyLTE4IGF0IDExOjIwIC0wODAwLCBTdGVwaGVuIEhlbW1pbmdlciB3cm90 ZToKPiBPbiBUdWUsIDE5IERlYyAyMDE3IDAwOjQxOjMwICswNTMwCj4gU2hyZWV5YSBQYXRlbCA8 c2hyZWV5YS5wYXRlbDIzNDk4QGdtYWlsLmNvbT4gd3JvdGU6Cj4gCj4gPiAKPiA+IERvIG5vdCBj aGVjayBmb3IgTk9UIE5VTEwgYmVmb3JlIGNhbGxpbmcga2ZyZWUgYmVjYXVzZSBpZiB0aGUKPiA+ IHBvaW50ZXIgaXMgTlVMTCwgbm8gYWN0aW9uIG9jY3Vycy4KPiA+IERvbmUgdXNpbmcgdGhlIGZv bGxvd2luZyBzZW1hbnRpYyBwYXRjaCBieSBjb2NjaW5lbGxlLgo+ID4gCj4gPiBAQAo+ID4gZXhw cmVzc2lvbiBwdHI7Cj4gPiBAQAo+ID4gCj4gPiAtIGlmIChwdHIgIT0gTlVMTCkgewo+ID4gwqAg a2ZyZWUocHRyKTsKPiA+IMKgIHB0ciA9IE5VTEw7Cj4gPiAtIH0KPiA+IAo+ID4gVGhlIHNlbWFu dGljIHBhdGNoIGhhcyB0aGUgZWZmZWN0IG9mIGFkZGluZyBhbiBhc3NpZ25tZW50Cj4gPiBvZiBw dHIgdG8gTlVMTCBpbiB0aGUgY2FzZSB3aGVyZSBwdHIgaXMgTlVMTCBhbHJlYWR5Lgo+ID4gCj4g PiBTaWduZWQtb2ZmLWJ5OiBTaHJlZXlhIFBhdGVsIDxzaHJlZXlhLnBhdGVsMjM0OThAZ21haWwu Y29tPgo+IFBsZWFzZSByZWFkIGRyaXZlcnMvc3RhZ2luZy9pcmRhL1RPRE8KCk9oLCBJIHdhcyBu b3Qga25vd2luZyBhYm91dCBpdC4KClRoYW5rIHlvdQo+IApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5nIGxpc3QKZGV2ZWxAbGludXhk cml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK