All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix indentation for intel_ddi_clk_select
Date: Tue, 19 Dec 2017 09:52:14 -0200	[thread overview]
Message-ID: <1513684334.2635.4.camel@intel.com> (raw)
In-Reply-To: <20171219112649.9388-1-chris@chris-wilson.co.uk>

Em Ter, 2017-12-19 às 11:26 +0000, Chris Wilson escreveu:
> drivers/gpu/drm/i915/intel_ddi.c:2098 intel_ddi_clk_select() warn:
> inconsistent indenting
> 
> References: 8edcda1266f9 ("drm/i915: Protect DDI port to DPLL map
> from theoretical race.")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index f624ba8e23be..f51645a08dca 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2095,7 +2095,7 @@ static void intel_ddi_clk_select(struct
> intel_encoder *encoder,
>  	if (WARN_ON(!pll))
>  		return;
>  
> -	 mutex_lock(&dev_priv->dpll_lock);
> +	mutex_lock(&dev_priv->dpll_lock);
>  
>  	if (IS_CANNONLAKE(dev_priv)) {
>  		/* Configure DPCLKA_CFGCR0 to map the DPLL to the
> DDI. */
> @@ -2117,7 +2117,7 @@ static void intel_ddi_clk_select(struct
> intel_encoder *encoder,
>  		val = I915_READ(DPLL_CTRL2);
>  
>  		val &= ~(DPLL_CTRL2_DDI_CLK_OFF(port) |
> -			DPLL_CTRL2_DDI_CLK_SEL_MASK(port));
> +			 DPLL_CTRL2_DDI_CLK_SEL_MASK(port));
>  		val |= (DPLL_CTRL2_DDI_CLK_SEL(pll->id, port) |
>  			DPLL_CTRL2_DDI_SEL_OVERRIDE(port));
>  
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-12-19 11:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 11:26 [PATCH] drm/i915: Fix indentation for intel_ddi_clk_select Chris Wilson
2017-12-19 11:52 ` Paulo Zanoni [this message]
2017-12-19 12:36 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-19 14:58 ` ✗ Fi.CI.IGT: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513684334.2635.4.camel@intel.com \
    --to=paulo.r.zanoni@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.