All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Will Deacon <will.deacon@arm.com>,
	Dave Martin <Dave.Martin@arm.com>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] scripts/decodecode: Make it take multiline Code line
Date: Tue, 19 Dec 2017 17:05:19 +0200	[thread overview]
Message-ID: <1513695919.7000.198.camel@linux.intel.com> (raw)
In-Reply-To: <20171212125105.2ad43a65f42a63cc6e4f4bcb@linux-foundation.org>

On Tue, 2017-12-12 at 12:51 -0800, Andrew Morton wrote:
> On Tue, 12 Dec 2017 12:03:23 +0200 Andy Shevchenko <andriy.shevchenko@
> linux.intel.com> wrote:
> 
> > In case of running scripts/decodecode without any parameters in
> > order to give a
> > copy'n'pasted Code line from, for example, email it would parse only
> > first line
> > of it, while in emails it's split to few.
> > 
> > So, add a logic to join this split back if and only if the following
> > lines have
> > hex digits, or spaces, or '<', or '>' characters. It will be quite
> > unlikely to
> > have a broken input in well formed Oops or dmesg, thus a simple
> > regex is being
> > used.
> 
> That's rather hard to understand.  An example would help?

When you have a file out of oops the Code line looks like

Code: hh hh ... <hh> ... hh\n

When copy'n'paste from, for example, email where sender or some middle
MTA split it, the line looks like:

Code: hh hh ... hh\n
hh ... <hh> ... hh\n
hh hh ... hh\n

The Code line followed by another oops line usually contains characters
out of hex digit + space + < + > set. That's what second paragraph
describes.

Should I resend with information above included?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-12-19 15:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12 10:03 [PATCH v1] scripts/decodecode: Make it take multiline Code line Andy Shevchenko
2017-12-12 20:51 ` Andrew Morton
2017-12-19 15:05   ` Andy Shevchenko [this message]
2017-12-19 22:54     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513695919.7000.198.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.