From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v4 0/5] Add Intel IOMMU debugfs support Date: Tue, 19 Dec 2017 23:25:10 +0200 Message-ID: <1513718710.7000.230.camel@linux.intel.com> References: <1513717687-82420-1-git-send-email-sohil.mehta@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1513717687-82420-1-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sohil Mehta , Joerg Roedel , Alex Williamson Cc: Ravi V Shankar , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, David Woodhouse , Gayatri Kammela List-Id: iommu@lists.linux-foundation.org On Tue, 2017-12-19 at 13:08 -0800, Sohil Mehta wrote: > Hi All, > > This series aims to add debugfs support for Intel IOMMU. It exposes > IOMMU > registers, internal context and dumps individual table entries to help > debug > Intel IOMMUs. > > The first patch does the ground work for the following patches by > creating a > new Kconfig option - INTEL_IOMMU_DEBUG. It also reorganizes some Intel > IOMMU > data structures. The next four patches add debugfs support for IOMMU > context > internals, register contents, PASID internals, and Interrupt remapping > in > that order. The information can be accessed in sysfs at > '/sys/kernel/debug/intel_iommu/'. Perhaps you need to switch to SPDX license pointer. I dunno if Thomas' patch with documentation how to do this made upstream / linux-next yet. > > Regards, > Sohil > > Changes since v3: > - Remove an unused function parameter from some of the functions > - Fix checkpatch.pl warnings > - Remove error reporting for debugfs_create_file functions > - Fix unnecessary reprogramming of the context entries > - Simplify and merge the show context and extended context patch into > one > - Remove redundant IOMMU null check under for_each_active_iommu > - Update the commit title to be consistent > > Changes since v2: > - Added a macro for seq file operations based on recommendation by > Andy > Shevchenko. The marco can be moved to seq_file.h at a future point > - Changed the debugfs file names to more relevant ones > - Added information for MTRR registers in the regset file > > Changes since v1: > - Fixed seq_printf formatting > - Handled the case when Interrupt remapping is not enabled > > Gayatri Kammela (4): > iommu/vt-d: Add debugfs support for Intel IOMMU internals > iommu/vt-d: Add debugfs support to show context internals > iommu/vt-d: Add debugfs support to show register contents > iommu/vt-d: Add debugfs support to show Pasid table contents > > Sohil Mehta (1): > iommu/vt-d: Add debugfs support for Interrupt remapping > > drivers/iommu/Kconfig | 10 ++ > drivers/iommu/Makefile | 1 + > drivers/iommu/intel-iommu-debug.c | 355 > ++++++++++++++++++++++++++++++++++++++ > drivers/iommu/intel-iommu.c | 35 +--- > drivers/iommu/intel-svm.c | 8 - > include/linux/intel-iommu.h | 34 ++++ > include/linux/intel-svm.h | 10 +- > 7 files changed, 416 insertions(+), 37 deletions(-) > create mode 100644 drivers/iommu/intel-iommu-debug.c > -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752379AbdLSV2Q (ORCPT ); Tue, 19 Dec 2017 16:28:16 -0500 Received: from mga03.intel.com ([134.134.136.65]:52270 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859AbdLSV2P (ORCPT ); Tue, 19 Dec 2017 16:28:15 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,428,1508828400"; d="scan'208";a="13692614" Message-ID: <1513718710.7000.230.camel@linux.intel.com> Subject: Re: [PATCH v4 0/5] Add Intel IOMMU debugfs support From: Andy Shevchenko To: Sohil Mehta , Joerg Roedel , Alex Williamson Cc: David Woodhouse , Ashok Raj , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jacob Pan , Gayatri Kammela , Ravi V Shankar , Lu Baolu Date: Tue, 19 Dec 2017 23:25:10 +0200 In-Reply-To: <1513717687-82420-1-git-send-email-sohil.mehta@intel.com> References: <1513717687-82420-1-git-send-email-sohil.mehta@intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-12-19 at 13:08 -0800, Sohil Mehta wrote: > Hi All, > > This series aims to add debugfs support for Intel IOMMU. It exposes > IOMMU > registers, internal context and dumps individual table entries to help > debug > Intel IOMMUs. > > The first patch does the ground work for the following patches by > creating a > new Kconfig option - INTEL_IOMMU_DEBUG. It also reorganizes some Intel > IOMMU > data structures. The next four patches add debugfs support for IOMMU > context > internals, register contents, PASID internals, and Interrupt remapping > in > that order. The information can be accessed in sysfs at > '/sys/kernel/debug/intel_iommu/'. Perhaps you need to switch to SPDX license pointer. I dunno if Thomas' patch with documentation how to do this made upstream / linux-next yet. > > Regards, > Sohil > > Changes since v3: > - Remove an unused function parameter from some of the functions > - Fix checkpatch.pl warnings > - Remove error reporting for debugfs_create_file functions > - Fix unnecessary reprogramming of the context entries > - Simplify and merge the show context and extended context patch into > one > - Remove redundant IOMMU null check under for_each_active_iommu > - Update the commit title to be consistent > > Changes since v2: > - Added a macro for seq file operations based on recommendation by > Andy > Shevchenko. The marco can be moved to seq_file.h at a future point > - Changed the debugfs file names to more relevant ones > - Added information for MTRR registers in the regset file > > Changes since v1: > - Fixed seq_printf formatting > - Handled the case when Interrupt remapping is not enabled > > Gayatri Kammela (4): > iommu/vt-d: Add debugfs support for Intel IOMMU internals > iommu/vt-d: Add debugfs support to show context internals > iommu/vt-d: Add debugfs support to show register contents > iommu/vt-d: Add debugfs support to show Pasid table contents > > Sohil Mehta (1): > iommu/vt-d: Add debugfs support for Interrupt remapping > > drivers/iommu/Kconfig | 10 ++ > drivers/iommu/Makefile | 1 + > drivers/iommu/intel-iommu-debug.c | 355 > ++++++++++++++++++++++++++++++++++++++ > drivers/iommu/intel-iommu.c | 35 +--- > drivers/iommu/intel-svm.c | 8 - > include/linux/intel-iommu.h | 34 ++++ > include/linux/intel-svm.h | 10 +- > 7 files changed, 416 insertions(+), 37 deletions(-) > create mode 100644 drivers/iommu/intel-iommu-debug.c > -- Andy Shevchenko Intel Finland Oy