From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v4 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping Date: Tue, 19 Dec 2017 23:30:20 +0200 Message-ID: <1513719020.7000.234.camel@linux.intel.com> References: <1513717687-82420-1-git-send-email-sohil.mehta@intel.com> <1513717687-82420-6-git-send-email-sohil.mehta@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1513717687-82420-6-git-send-email-sohil.mehta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sohil Mehta , Joerg Roedel , Alex Williamson Cc: Ravi V Shankar , Fenghua Yu , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, David Woodhouse , Gayatri Kammela List-Id: iommu@lists.linux-foundation.org On Tue, 2017-12-19 at 13:08 -0800, Sohil Mehta wrote: > Debugfs extension for Intel IOMMU to dump Interrupt remapping table > entries for Interrupt remapping and Interrupt posting. > > The file /sys/kernel/debug/intel_iommu/ir_translation_struct provides > detailed information, such as Index, Source Id, Destination Id, Vector > and the raw values for entries with the present bit set, in the format > shown. > > Remapped Interrupt supported on IOMMU: dmar5 > IR table address:ffff93e09d54c310 > ----------------------------------------------------------- > Index SID Dest_ID Vct Raw_value_high Raw_value_low > 1 3a00 00000600 2c 0000000000043a00 00000600002c0009 > 111 4301 00000900 a2 0000000000044301 0000090000a20009 > > Posted Interrupt supported on IOMMU: dmar5 > IR table address:ffff93e09d54c310 > -------------------------------------------------------------------- > Index SID PDA_high PDA_low Vct Raw_value_high Raw_value_low > 4 4300 00000010 40c7c880 41 0000001000044300 40c7c88000418001 > 5 4300 00000010 40c7c880 51 0000001000044300 40c7c88000518001 > > > + seq_printf(m, "\nRemapped Interrupt supported on > IOMMU: %s\n" Please, avoid leading \n. > + " IR table address:%p\n", iommu->name, > + iommu->ir_table); > + > + seq_puts(m, "-------------------------------------- > ---------" > + "------------\n"); It's okay to use long string literal on one line. So, don't split (or for multi-line string literals, split by \n like you do above). > + seq_puts(m, > "\n****\t****\t****\t****\t****\t****\t****\t****\n"); Leading \n. > + seq_printf(m, "\nPosted Interrupt supported on IOMMU: > %s\n" Ditto. > + " IR table address:%p\n", iommu->name, > + iommu->ir_table); > + > + seq_puts(m, "-------------------------------------- > ----------" > + "--------------------\n"); Join back. -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752908AbdLSVa1 (ORCPT ); Tue, 19 Dec 2017 16:30:27 -0500 Received: from mga09.intel.com ([134.134.136.24]:35819 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbdLSVaZ (ORCPT ); Tue, 19 Dec 2017 16:30:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,428,1508828400"; d="scan'208";a="13693060" Message-ID: <1513719020.7000.234.camel@linux.intel.com> Subject: Re: [PATCH v4 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping From: Andy Shevchenko To: Sohil Mehta , Joerg Roedel , Alex Williamson Cc: David Woodhouse , Ashok Raj , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Jacob Pan , Gayatri Kammela , Ravi V Shankar , Lu Baolu , Fenghua Yu Date: Tue, 19 Dec 2017 23:30:20 +0200 In-Reply-To: <1513717687-82420-6-git-send-email-sohil.mehta@intel.com> References: <1513717687-82420-1-git-send-email-sohil.mehta@intel.com> <1513717687-82420-6-git-send-email-sohil.mehta@intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-12-19 at 13:08 -0800, Sohil Mehta wrote: > Debugfs extension for Intel IOMMU to dump Interrupt remapping table > entries for Interrupt remapping and Interrupt posting. > > The file /sys/kernel/debug/intel_iommu/ir_translation_struct provides > detailed information, such as Index, Source Id, Destination Id, Vector > and the raw values for entries with the present bit set, in the format > shown. > > Remapped Interrupt supported on IOMMU: dmar5 > IR table address:ffff93e09d54c310 > ----------------------------------------------------------- > Index SID Dest_ID Vct Raw_value_high Raw_value_low > 1 3a00 00000600 2c 0000000000043a00 00000600002c0009 > 111 4301 00000900 a2 0000000000044301 0000090000a20009 > > Posted Interrupt supported on IOMMU: dmar5 > IR table address:ffff93e09d54c310 > -------------------------------------------------------------------- > Index SID PDA_high PDA_low Vct Raw_value_high Raw_value_low > 4 4300 00000010 40c7c880 41 0000001000044300 40c7c88000418001 > 5 4300 00000010 40c7c880 51 0000001000044300 40c7c88000518001 > > > + seq_printf(m, "\nRemapped Interrupt supported on > IOMMU: %s\n" Please, avoid leading \n. > + " IR table address:%p\n", iommu->name, > + iommu->ir_table); > + > + seq_puts(m, "-------------------------------------- > ---------" > + "------------\n"); It's okay to use long string literal on one line. So, don't split (or for multi-line string literals, split by \n like you do above). > + seq_puts(m, > "\n****\t****\t****\t****\t****\t****\t****\t****\n"); Leading \n. > + seq_printf(m, "\nPosted Interrupt supported on IOMMU: > %s\n" Ditto. > + " IR table address:%p\n", iommu->name, > + iommu->ir_table); > + > + seq_puts(m, "-------------------------------------- > ----------" > + "--------------------\n"); Join back. -- Andy Shevchenko Intel Finland Oy