From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mehta, Sohil" Subject: Re: [PATCH v4 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping Date: Wed, 20 Dec 2017 00:42:39 +0000 Message-ID: <1513730591.31078.25.camel@intel.com> References: <1513717687-82420-1-git-send-email-sohil.mehta@intel.com> <1513717687-82420-6-git-send-email-sohil.mehta@intel.com> <1513719020.7000.234.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1513719020.7000.234.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Content-Language: en-US Content-ID: <5330F53A44390D42ABB64BD64FF8AFD5-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org" , "andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" , "alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" Cc: "Yu, Fenghua" , "Shankar, Ravi V" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org" , "Kammela, Gayatri" List-Id: iommu@lists.linux-foundation.org DQpPbiBUdWUsIDIwMTctMTItMTkgYXQgMjM6MzAgKzAyMDAsIEFuZHkgU2hldmNoZW5rbyB3cm90 ZToNCj4gT24gVHVlLCAyMDE3LTEyLTE5IGF0IDEzOjA4IC0wODAwLCBTb2hpbCBNZWh0YSB3cm90 ZToNCj4gPiANCj4gPiBEZWJ1Z2ZzIGV4dGVuc2lvbiBmb3IgSW50ZWwgSU9NTVUgdG8gZHVtcCBJ bnRlcnJ1cHQgcmVtYXBwaW5nIHRhYmxlDQo+ID4gZW50cmllcyBmb3IgSW50ZXJydXB0IHJlbWFw cGluZyBhbmQgSW50ZXJydXB0IHBvc3RpbmcuDQo+ID4gDQo+ID4gVGhlIGZpbGUgL3N5cy9rZXJu ZWwvZGVidWcvaW50ZWxfaW9tbXUvaXJfdHJhbnNsYXRpb25fc3RydWN0DQo+ID4gcHJvdmlkZXMN Cj4gPiBkZXRhaWxlZCBpbmZvcm1hdGlvbiwgc3VjaCBhcyBJbmRleCwgU291cmNlIElkLCBEZXN0 aW5hdGlvbiBJZCwNCj4gPiBWZWN0b3INCj4gPiBhbmQgdGhlIHJhdyB2YWx1ZXMgZm9yIGVudHJp ZXMgd2l0aCB0aGUgcHJlc2VudCBiaXQgc2V0LCBpbiB0aGUNCj4gPiBmb3JtYXQNCj4gPiBzaG93 bi4NCj4gPiANCj4gPiBSZW1hcHBlZCBJbnRlcnJ1cHQgc3VwcG9ydGVkIG9uIElPTU1VOiBkbWFy NQ0KPiA+IMKgSVIgdGFibGUgYWRkcmVzczpmZmZmOTNlMDlkNTRjMzEwDQo+ID4gLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gPiDC oEluZGV4wqDCoFNJRMKgwqBEZXN0X0lEwqDCoFZjdCBSYXdfdmFsdWVfaGlnaMKgwqDCoFJhd192 YWx1ZV9sb3cNCj4gPiDCoDHCoMKgwqDCoMKgwqAzYTAwIDAwMDAwNjAwIDJjwqDCoDAwMDAwMDAw MDAwNDNhMDAgMDAwMDA2MDAwMDJjMDAwOQ0KPiA+IMKgMTExwqDCoMKgwqA0MzAxIDAwMDAwOTAw IGEywqDCoDAwMDAwMDAwMDAwNDQzMDEgMDAwMDA5MDAwMGEyMDAwOQ0KPiA+IA0KPiA+IFBvc3Rl ZCBJbnRlcnJ1cHQgc3VwcG9ydGVkIG9uIElPTU1VOiBkbWFyNQ0KPiA+IMKgSVIgdGFibGUgYWRk cmVzczpmZmZmOTNlMDlkNTRjMzEwDQo+ID4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gPiAtLS0NCj4gPiDCoEluZGV4 wqDCoFNJRMKgwqBQREFfaGlnaCBQREFfbG93wqDCoFZjdCBSYXdfdmFsdWVfaGlnaMKgwqDCoFJh d192YWx1ZV9sb3cNCj4gPiDCoDTCoMKgwqDCoMKgwqA0MzAwIDAwMDAwMDEwIDQwYzdjODgwIDQx wqDCoDAwMDAwMDEwMDAwNDQzMDANCj4gPiA0MGM3Yzg4MDAwNDE4MDAxDQo+ID4gwqA1wqDCoMKg wqDCoMKgNDMwMCAwMDAwMDAxMCA0MGM3Yzg4MCA1McKgwqAwMDAwMDAxMDAwMDQ0MzAwDQo+ID4g NDBjN2M4ODAwMDUxODAwMQ0KPiA+IA0KPiA+IA0KPiA+IA0KPiA+ICsJCXNlcV9wcmludGYobSwg IlxuUmVtYXBwZWQgSW50ZXJydXB0IHN1cHBvcnRlZCBvbg0KPiA+IElPTU1VOiAlc1xuIg0KPiBQ bGVhc2UsIGF2b2lkIGxlYWRpbmcgXG4uDQoNClN1cmUuIEknbGwgYWRkIGEgc2VwYXJhdGUgc2Vx X3B1dHMobSwgIlxuIikgYWZ0ZXIgZWFjaCBvZiB0aGUgbG9vcHMgdG8NCmF2b2lkIGhhdmluZyB0 aGUgbGVhZGluZyAnXG4ncy4NCg0KPiANCj4gPiANCj4gPiArCQkJwqDCoMKgIiBJUiB0YWJsZSBh ZGRyZXNzOiVwXG4iLCBpb21tdS0+bmFtZSwNCj4gPiArCQkJwqDCoMKgaW9tbXUtPmlyX3RhYmxl KTsNCj4gPiArDQo+ID4gKwkJc2VxX3B1dHMobSwgIi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0NCj4gPiAtDQo+ID4gLS0tLS0tLS0tIg0KPiA+ICsJCQnCoCItLS0tLS0tLS0t LS1cbiIpOw0KPiBJdCdzIG9rYXkgdG8gdXNlIGxvbmcgc3RyaW5nIGxpdGVyYWwgb24gb25lIGxp bmUuIFNvLCBkb24ndCBzcGxpdCAob3INCj4gZm9yIG11bHRpLWxpbmUgc3RyaW5nIGxpdGVyYWxz LCBzcGxpdCBieSBcbiBsaWtlIHlvdSBkbyBhYm92ZSkuDQo+IA0KVGhhbmtzLiBXaWxsIGZpeCB0 aGlzIGFuZCB0aGUgb3RoZXIgb25lLg0KDQo+ID4gDQo+ID4gKwlzZXFfcHV0cyhtLA0KPiA+ICJc bioqKipcdCoqKipcdCoqKipcdCoqKipcdCoqKipcdCoqKipcdCoqKipcdCoqKipcbiIpOw0KPiBM ZWFkaW5nIFxuLg0KPiANCj4gPiANCj4gPiArCQlzZXFfcHJpbnRmKG0sICJcblBvc3RlZCBJbnRl cnJ1cHQgc3VwcG9ydGVkIG9uDQo+ID4gSU9NTVU6DQo+ID4gJXNcbiINCj4gRGl0dG8uDQo+IA0K PiA+IA0KPiA+ICsJCQnCoMKgwqAiIElSIHRhYmxlIGFkZHJlc3M6JXBcbiIsIGlvbW11LT5uYW1l LA0KPiA+ICsJCQnCoMKgwqBpb21tdS0+aXJfdGFibGUpOw0KPiA+ICsNCj4gPiArCQlzZXFfcHV0 cyhtLCAiLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+IC0NCj4gPiAt LS0tLS0tLS0tIg0KPiA+ICsJCQnCoCItLS0tLS0tLS0tLS0tLS0tLS0tLVxuIik7DQo+IEpvaW4g YmFjay4NCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRw czovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958AbdLTAmn (ORCPT ); Tue, 19 Dec 2017 19:42:43 -0500 Received: from mga03.intel.com ([134.134.136.65]:64636 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753740AbdLTAmm (ORCPT ); Tue, 19 Dec 2017 19:42:42 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,429,1508828400"; d="scan'208";a="3877971" From: "Mehta, Sohil" To: "joro@8bytes.org" , "andriy.shevchenko@linux.intel.com" , "alex.williamson@redhat.com" CC: "linux-kernel@vger.kernel.org" , "Raj, Ashok" , "Yu, Fenghua" , "baolu.lu@linux.intel.com" , "jacob.jun.pan@linux.intel.com" , "iommu@lists.linux-foundation.org" , "Kammela, Gayatri" , "Shankar, Ravi V" , "dwmw2@infradead.org" Subject: Re: [PATCH v4 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping Thread-Topic: [PATCH v4 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping Thread-Index: AQHTeQ11CYrVZ3CegE22o3yfPU5tlaNLtSUAgAA14oA= Date: Wed, 20 Dec 2017 00:42:39 +0000 Message-ID: <1513730591.31078.25.camel@intel.com> References: <1513717687-82420-1-git-send-email-sohil.mehta@intel.com> <1513717687-82420-6-git-send-email-sohil.mehta@intel.com> <1513719020.7000.234.camel@linux.intel.com> In-Reply-To: <1513719020.7000.234.camel@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.110.4] Content-Type: text/plain; charset="utf-8" Content-ID: <5330F53A44390D42ABB64BD64FF8AFD5@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBK0gnih013569 On Tue, 2017-12-19 at 23:30 +0200, Andy Shevchenko wrote: > On Tue, 2017-12-19 at 13:08 -0800, Sohil Mehta wrote: > > > > Debugfs extension for Intel IOMMU to dump Interrupt remapping table > > entries for Interrupt remapping and Interrupt posting. > > > > The file /sys/kernel/debug/intel_iommu/ir_translation_struct > > provides > > detailed information, such as Index, Source Id, Destination Id, > > Vector > > and the raw values for entries with the present bit set, in the > > format > > shown. > > > > Remapped Interrupt supported on IOMMU: dmar5 > >  IR table address:ffff93e09d54c310 > > ----------------------------------------------------------- > >  Index  SID  Dest_ID  Vct Raw_value_high   Raw_value_low > >  1      3a00 00000600 2c  0000000000043a00 00000600002c0009 > >  111    4301 00000900 a2  0000000000044301 0000090000a20009 > > > > Posted Interrupt supported on IOMMU: dmar5 > >  IR table address:ffff93e09d54c310 > > ----------------------------------------------------------------- > > --- > >  Index  SID  PDA_high PDA_low  Vct Raw_value_high   Raw_value_low > >  4      4300 00000010 40c7c880 41  0000001000044300 > > 40c7c88000418001 > >  5      4300 00000010 40c7c880 51  0000001000044300 > > 40c7c88000518001 > > > > > > > > + seq_printf(m, "\nRemapped Interrupt supported on > > IOMMU: %s\n" > Please, avoid leading \n. Sure. I'll add a separate seq_puts(m, "\n") after each of the loops to avoid having the leading '\n's. > > > > > +    " IR table address:%p\n", iommu->name, > > +    iommu->ir_table); > > + > > + seq_puts(m, "------------------------------------- > > - > > ---------" > > +  "------------\n"); > It's okay to use long string literal on one line. So, don't split (or > for multi-line string literals, split by \n like you do above). > Thanks. Will fix this and the other one. > > > > + seq_puts(m, > > "\n****\t****\t****\t****\t****\t****\t****\t****\n"); > Leading \n. > > > > > + seq_printf(m, "\nPosted Interrupt supported on > > IOMMU: > > %s\n" > Ditto. > > > > > +    " IR table address:%p\n", iommu->name, > > +    iommu->ir_table); > > + > > + seq_puts(m, "------------------------------------- > > - > > ----------" > > +  "--------------------\n"); > Join back. >