From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW Date: Wed, 20 Dec 2017 02:55:07 -0800 Message-ID: <1513767307.1234.114.camel@perches.com> References: <20171220083403.GA27231@bitmer.com> <1513761884.1234.83.camel@perches.com> <20171220093211.GA16177@kroah.com> <1513763681.1234.101.camel@perches.com> <20171220095926.GA24285@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171220095926.GA24285@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg Kroah-Hartman , Julia Lawall Cc: linux-fbdev@vger.kernel.org, David Airlie , Joonas Lahtinen , Heiko Carstens , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Jaroslav Kysela , Peter Ujfalusi , linux-s390@vger.kernel.org, linux-omap@vger.kernel.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, Takashi Iwai , Sebastian Ott , James Smart , Cezary Jackiewicz , linux-serial@vger.kernel.org, Jiri Slaby , Darren Hart , Zhang Rui , Dick Kennedy , Mathias Nyman , Bartlomiej Zolnierkiewicz , Peter Oberparleiter List-Id: alsa-devel@alsa-project.org T24gV2VkLCAyMDE3LTEyLTIwIGF0IDEwOjU5ICswMTAwLCBHcmVnIEtyb2FoLUhhcnRtYW4gd3Jv dGU6Cj4gPiA+IFdoeSB5b3UgZGlkbid0IHNlbmQgdGhhdCBwYXRjaCB0byB0aGUgc3lzZnMgbWFp bnRhaW5lciBpcyBhIGJpdCBvZGQuLi4gIDopCj4gPiAKPiA+IFNvIGhlcmUncyBhbiBvcHBvcnR1 bml0eSBmb3IgeW91Ogo+ID4gCj4gPiBUaGUgc3lzZnMgbWFpbnRhaW5lciBoYXNuJ3QgYWRkZWQg aW5jbHVkZS9saW51eC9zeXNmcy5oIHRvCj4gPiB0aGUgbGlzdCBvZiBtYWludGFpbmVkIGZpbGVz Li4uCj4gPiAKPiA+IERSSVZFUiBDT1JFLCBLT0JKRUNUUywgREVCVUdGUyBBTkQgU1lTRlMKPiA+ IE06CUdyZWcgS3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gPiBU OglnaXQgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2dyZWdr aC9kcml2ZXItY29yZS5naXQKPiA+IFM6CVN1cHBvcnRlZAo+ID4gRjoJRG9jdW1lbnRhdGlvbi9r b2JqZWN0LnR4dAo+ID4gRjoJZHJpdmVycy9iYXNlLwo+ID4gRjoJZnMvZGVidWdmcy8KPiA+IEY6 CWZzL3N5c2ZzLwo+ID4gRjoJaW5jbHVkZS9saW51eC9kZWJ1Z2ZzLmgKPiA+IEY6CWluY2x1ZGUv bGludXgva29iaioKPiA+IEY6CWxpYi9rb2JqKgo+IAo+IEhlaCwgZ29vZCBwb2ludCwgYnV0IHVz aW5nIGdldF9tYWludGFpbmVyLnBsIGRvZXMgcHV0IG1lIGF0IHRoZSB0b3Agb2YKPiB0aGUgbGlz dCB0aGF0IHlvdSBzaG91bGQgYmUgY2M6aW5nOgo+IAo+ICQgLi9zY3JpcHRzL2dldF9tYWludGFp bmVyLnBsIC0tZmlsZSBpbmNsdWRlL2xpbnV4L3N5c2ZzLmgKPiBHcmVnIEtyb2FoLUhhcnRtYW4g PGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPiAoY29tbWl0X3NpZ25lcjozLzM9MTAwJSxhdXRo b3JlZDoyLzM9NjclLGFkZGVkX2xpbmVzOjcvOD04OCUpCj4gS2F0ZSBTdGV3YXJ0IDxrc3Rld2Fy dEBsaW51eGZvdW5kYXRpb24ub3JnPiAoY29tbWl0X3NpZ25lcjoxLzM9MzMlKQo+IFRob21hcyBH bGVpeG5lciA8dGdseEBsaW51dHJvbml4LmRlPiAoY29tbWl0X3NpZ25lcjoxLzM9MzMlKQo+IFBo aWxpcHBlIE9tYnJlZGFubmUgPHBvbWJyZWRhbm5lQG5leGIuY29tPiAoY29tbWl0X3NpZ25lcjox LzM9MzMlKQo+IE5pY2sgRGVzYXVsbmllcnMgPG5pY2suZGVzYXVsbmllcnNAZ21haWwuY29tPiAo Y29tbWl0X3NpZ25lcjoxLzM9MzMlLGF1dGhvcmVkOjEvMz0zMyUsYWRkZWRfbGluZXM6MS84PTEy JSxyZW1vdmVkX2xpbmVzOjEvMT0xMDAlKQo+IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcg KG9wZW4gbGlzdCkKClRoZSBzY3JpcHQgSSB1c2UgdG8gc2VuZCBwYXRjaGVzIGFkZHMgLS1ub2dp dCAtLW5vZ2l0LWZhbGxiYWNrCnRvIGNvcHkgb25seSBsaXN0ZWQgbWFpbnRhaW5lcnMgYmVjYXVz ZSBwZW9wbGUgdGhhdCBzZW5kIGNsZWFudXAKcGF0Y2hlcyBkb24ndCBnZW5lcmFsbHkgbGlrZSB0 byBnZXQgcmFuZG9tIHBhdGNoZXMuCgo+ID4gYnR3OiB0aGVyZSBhcmUgbWFueSB1c2VzIG9mIGEg cmV2ZXJzZWQgZGVjbGFyYXRpb24gc3R5bGUgb2YgREVWSUNFX0FUVFIKPiA+IAo+ID4gSGVyZSdz IGFub3RoZXIgdGhpbmcgdGhhdCBjb3VsZCBiZSBkb25lIGZvciBtb3JlIERFVklDRV9BVFRSXzxG T08+IHVzZXMuCj4gPiAKPiA+ID09PQo+ID4gCj4gPiBTb21lIERFVklDRV9BVFRSIGRlZmluaXRp b25zIHVzZSBhIHJldmVyc2VkIHN0YXRpYyBmdW5jdGlvbiBmb3JtIGZyb20KPiA+IHRoZSB0eXBp Y2FsLiAgQ29udmVydCB0aGVtIHRvIHVzZSB0aGUgbW9yZSBjb21tb24gbWFjcm8gZm9ybSBzbyBp dCBpcwo+ID4gZWFzaWVyIHRvIGdyZXAgZm9yIHRoZSBzdHlsZS4KW10KPiA+ICQgZ2l0IGdyZXAg LS1uYW1lLW9ubHkgLXcgREVWSUNFX0FUVFIgfCBcCj4gPiAgIHhhcmdzIHBlcmwgLWkgZGV2X2F0 dHJfcndfYmFja3dhcmRzLnBlcmwKPiBBaCwgbmljZSwgSSBsb3ZlIHBlcmwgOgoKVGhhdCB3YXMg YSBiYWQgY29weS9wYXN0ZSBvZiB0aGUgc2NyaXB0LgoKVGhlIGFjdHVhbCBzY3JpcHQgZm9yIFJX IGlzOgoKJCBjYXQgZGV2X2F0dHJfcndfYmFja3dhcmRzLnBlcmwKbG9jYWwgJC87CndoaWxlICg8 PikgewogICAgbXkgJGZpbGUgPSAkXzsKICAgIHdoaWxlICgkZmlsZSA9fiBtL1xiREVWSUNFX0FU VFJccypcKFxzKihcdyspXHMqLC9nKSB7CglteSAkdmFyID0gJDE7CglpZiAoJGZpbGUgPX4gcy9c YkRFVklDRV9BVFRSXHMqXChccyoke3Zhcn1ccyosXHMqXCg/KFxzKlNfSVJVR09ccypcfFxzKlNf SVdVU1J8XHMqU19JV1VTUlxzKlx8XHMqU19JUlVHT1xzKnxccyowNjQ0XHMqKVwpP1xzKixccypz aG93XyR7dmFyfVxzKixccypzdG9yZV8ke3Zhcn1ccypcKS9ERVZJQ0VfQVRUUl9SVygke3Zhcn0p L2cpIHsKCSAgICAkZmlsZSA9fiBzL1xic2hvd18ke3Zhcn1cYi8ke3Zhcn1fc2hvdy9nOwoJICAg ICRmaWxlID1+IHMvXGJzdG9yZV8ke3Zhcn1cYi8ke3Zhcn1fc3RvcmUvZzsKCX0KICAgIH0KICAg IHByaW50ICRmaWxlOwp9CgpUaGVyZSBhcmUgMyBkaWZmZXJlbnQgcGVybCBzY3JpcHRzIGZvciBy dywgcm8sIGFuZCB3by4KYW5kIHRoZXNlIHNjcmlwdHMsIGJlY2F1c2Ugb2YgZnVuY3Rpb24gcmVu YW1pbmcgYW5kCnBvc3NpYmxlIHJldXNlIG9mIHRoZSBvcmlnaW5hbCBmdW5jdGlvbiBuYW1lcyBi eSBvdGhlcgpzdHJpbmcgY29uY2F0ZW5hdGVkIG1hY3JvcywgY3JlYXRlIHNvbWUgYmFkIGNvbnZl cnNpb25zCnNvIHRoZXkgbmVlZCBzb21lIG1hbnVhbCBjbGVhbnVwcyB0b28uCgpQZXJoYXBzIGNv Y2NpbmVsbGUgY291bGQgZG8gYSBiZXR0ZXIgam9iIG9mIGl0LCBidXQKbGlrZWx5IHN0cmluZyBj b25jYXRlbmF0aW9uIG1hY3JvIHVzZXMgYXJlIGdvaW5nIHRvCmJlIGhhcmQgdG8gZGVhbCB3aXRo IGluIGFueSBjYXNlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Wed, 20 Dec 2017 10:55:07 +0000 Subject: Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW Message-Id: <1513767307.1234.114.camel@perches.com> List-Id: References: <20171220083403.GA27231@bitmer.com> <1513761884.1234.83.camel@perches.com> <20171220093211.GA16177@kroah.com> <1513763681.1234.101.camel@perches.com> <20171220095926.GA24285@kroah.com> In-Reply-To: <20171220095926.GA24285@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Greg Kroah-Hartman , Julia Lawall Cc: linux-fbdev@vger.kernel.org, David Airlie , Joonas Lahtinen , Heiko Carstens , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Jaroslav Kysela , Peter Ujfalusi , linux-s390@vger.kernel.org, linux-omap@vger.kernel.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, Takashi Iwai , Sebastian Ott , James Smart , Cezary Jackiewicz , linux-serial@vger.kernel.org, Jiri Slaby , Darren Hart , Zhang Rui , Dick Kennedy , Mathias Nyman , Bartlomiej Zolnierkiewicz , Peter Oberparleiter On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote: > > > Why you didn't send that patch to the sysfs maintainer is a bit odd..= . :) > >=20 > > So here's an opportunity for you: > >=20 > > The sysfs maintainer hasn't added include/linux/sysfs.h to > > the list of maintained files... > >=20 > > DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS > > M: Greg Kroah-Hartman > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core= .git > > S: Supported > > F: Documentation/kobject.txt > > F: drivers/base/ > > F: fs/debugfs/ > > F: fs/sysfs/ > > F: include/linux/debugfs.h > > F: include/linux/kobj* > > F: lib/kobj* >=20 > Heh, good point, but using get_maintainer.pl does put me at the top of > the list that you should be cc:ing: >=20 > $ ./scripts/get_maintainer.pl --file include/linux/sysfs.h > Greg Kroah-Hartman (commit_signer:3/3=100%,a= uthored:2/3g%,added_lines:7/8=88%) > Kate Stewart (commit_signer:1/33%) > Thomas Gleixner (commit_signer:1/33%) > Philippe Ombredanne (commit_signer:1/33%) > Nick Desaulniers (commit_signer:1/33%,author= ed:1/33%,added_lines:1/8=12%,removed_lines:1/1=100%) > linux-kernel@vger.kernel.org (open list) The script I use to send patches adds --nogit --nogit-fallback to copy only listed maintainers because people that send cleanup patches don't generally like to get random patches. > > btw: there are many uses of a reversed declaration style of DEVICE_ATTR > >=20 > > Here's another thing that could be done for more DEVICE_ATTR_ uses. > >=20 > > =3D> >=20 > > Some DEVICE_ATTR definitions use a reversed static function form from > > the typical. Convert them to use the more common macro form so it is > > easier to grep for the style. [] > > $ git grep --name-only -w DEVICE_ATTR | \ > > xargs perl -i dev_attr_rw_backwards.perl > Ah, nice, I love perl : That was a bad copy/paste of the script. The actual script for RW is: $ cat dev_attr_rw_backwards.perl local $/; while (<>) { my $file =3D $_; while ($file =3D~ m/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,/g) { my $var =3D $1; if ($file =3D~ s/\bDEVICE_ATTR\s*\(\s*${var}\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S= _IWUSR|\s*S_IWUSR\s*\|\s*S_IRUGO\s*|\s*0644\s*)\)?\s*,\s*show_${var}\s*,\s*= store_${var}\s*\)/DEVICE_ATTR_RW(${var})/g) { $file =3D~ s/\bshow_${var}\b/${var}_show/g; $file =3D~ s/\bstore_${var}\b/${var}_store/g; } } print $file; } There are 3 different perl scripts for rw, ro, and wo. and these scripts, because of function renaming and possible reuse of the original function names by other string concatenated macros, create some bad conversions so they need some manual cleanups too. Perhaps coccinelle could do a better job of it, but likely string concatenation macro uses are going to be hard to deal with in any case. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next,2/4] treewide: Use DEVICE_ATTR_RW From: Joe Perches Message-Id: <1513767307.1234.114.camel@perches.com> Date: Wed, 20 Dec 2017 02:55:07 -0800 To: Greg Kroah-Hartman , Julia Lawall Cc: Jarkko Nikula , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Cezary Jackiewicz , Darren Hart , Andy Shevchenko , Sebastian Ott , Peter Oberparleiter , James Smart , Dick Kennedy , Zhang Rui , Eduardo Valentin , Mathias Nyman , Felipe Balbi , "Luis R. Rodriguez" , Peter Ujfalusi , Martin Schwidefsky , Heiko Carstens , David Airlie , "James E.J. Bottomley" , "Martin K. Petersen" , Jiri Slaby , Bartlomiej Zolnierkiewicz , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org List-ID: T24gV2VkLCAyMDE3LTEyLTIwIGF0IDEwOjU5ICswMTAwLCBHcmVnIEtyb2FoLUhhcnRtYW4gd3Jv dGU6Cj4gPiA+IFdoeSB5b3UgZGlkbid0IHNlbmQgdGhhdCBwYXRjaCB0byB0aGUgc3lzZnMgbWFp bnRhaW5lciBpcyBhIGJpdCBvZGQuLi4gIDopCj4gPiAKPiA+IFNvIGhlcmUncyBhbiBvcHBvcnR1 bml0eSBmb3IgeW91Ogo+ID4gCj4gPiBUaGUgc3lzZnMgbWFpbnRhaW5lciBoYXNuJ3QgYWRkZWQg aW5jbHVkZS9saW51eC9zeXNmcy5oIHRvCj4gPiB0aGUgbGlzdCBvZiBtYWludGFpbmVkIGZpbGVz Li4uCj4gPiAKPiA+IERSSVZFUiBDT1JFLCBLT0JKRUNUUywgREVCVUdGUyBBTkQgU1lTRlMKPiA+ IE06CUdyZWcgS3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gPiBU OglnaXQgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2dyZWdr aC9kcml2ZXItY29yZS5naXQKPiA+IFM6CVN1cHBvcnRlZAo+ID4gRjoJRG9jdW1lbnRhdGlvbi9r b2JqZWN0LnR4dAo+ID4gRjoJZHJpdmVycy9iYXNlLwo+ID4gRjoJZnMvZGVidWdmcy8KPiA+IEY6 CWZzL3N5c2ZzLwo+ID4gRjoJaW5jbHVkZS9saW51eC9kZWJ1Z2ZzLmgKPiA+IEY6CWluY2x1ZGUv bGludXgva29iaioKPiA+IEY6CWxpYi9rb2JqKgo+IAo+IEhlaCwgZ29vZCBwb2ludCwgYnV0IHVz aW5nIGdldF9tYWludGFpbmVyLnBsIGRvZXMgcHV0IG1lIGF0IHRoZSB0b3Agb2YKPiB0aGUgbGlz dCB0aGF0IHlvdSBzaG91bGQgYmUgY2M6aW5nOgo+IAo+ICQgLi9zY3JpcHRzL2dldF9tYWludGFp bmVyLnBsIC0tZmlsZSBpbmNsdWRlL2xpbnV4L3N5c2ZzLmgKPiBHcmVnIEtyb2FoLUhhcnRtYW4g PGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPiAoY29tbWl0X3NpZ25lcjozLzM9MTAwJSxhdXRo b3JlZDoyLzM9NjclLGFkZGVkX2xpbmVzOjcvOD04OCUpCj4gS2F0ZSBTdGV3YXJ0IDxrc3Rld2Fy dEBsaW51eGZvdW5kYXRpb24ub3JnPiAoY29tbWl0X3NpZ25lcjoxLzM9MzMlKQo+IFRob21hcyBH bGVpeG5lciA8dGdseEBsaW51dHJvbml4LmRlPiAoY29tbWl0X3NpZ25lcjoxLzM9MzMlKQo+IFBo aWxpcHBlIE9tYnJlZGFubmUgPHBvbWJyZWRhbm5lQG5leGIuY29tPiAoY29tbWl0X3NpZ25lcjox LzM9MzMlKQo+IE5pY2sgRGVzYXVsbmllcnMgPG5pY2suZGVzYXVsbmllcnNAZ21haWwuY29tPiAo Y29tbWl0X3NpZ25lcjoxLzM9MzMlLGF1dGhvcmVkOjEvMz0zMyUsYWRkZWRfbGluZXM6MS84PTEy JSxyZW1vdmVkX2xpbmVzOjEvMT0xMDAlKQo+IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcg KG9wZW4gbGlzdCkKClRoZSBzY3JpcHQgSSB1c2UgdG8gc2VuZCBwYXRjaGVzIGFkZHMgLS1ub2dp dCAtLW5vZ2l0LWZhbGxiYWNrCnRvIGNvcHkgb25seSBsaXN0ZWQgbWFpbnRhaW5lcnMgYmVjYXVz ZSBwZW9wbGUgdGhhdCBzZW5kIGNsZWFudXAKcGF0Y2hlcyBkb24ndCBnZW5lcmFsbHkgbGlrZSB0 byBnZXQgcmFuZG9tIHBhdGNoZXMuCgo+ID4gYnR3OiB0aGVyZSBhcmUgbWFueSB1c2VzIG9mIGEg cmV2ZXJzZWQgZGVjbGFyYXRpb24gc3R5bGUgb2YgREVWSUNFX0FUVFIKPiA+IAo+ID4gSGVyZSdz IGFub3RoZXIgdGhpbmcgdGhhdCBjb3VsZCBiZSBkb25lIGZvciBtb3JlIERFVklDRV9BVFRSXzxG T08+IHVzZXMuCj4gPiAKPiA+ID09PQo+ID4gCj4gPiBTb21lIERFVklDRV9BVFRSIGRlZmluaXRp b25zIHVzZSBhIHJldmVyc2VkIHN0YXRpYyBmdW5jdGlvbiBmb3JtIGZyb20KPiA+IHRoZSB0eXBp Y2FsLiAgQ29udmVydCB0aGVtIHRvIHVzZSB0aGUgbW9yZSBjb21tb24gbWFjcm8gZm9ybSBzbyBp dCBpcwo+ID4gZWFzaWVyIHRvIGdyZXAgZm9yIHRoZSBzdHlsZS4KW10KPiA+ICQgZ2l0IGdyZXAg LS1uYW1lLW9ubHkgLXcgREVWSUNFX0FUVFIgfCBcCj4gPiAgIHhhcmdzIHBlcmwgLWkgZGV2X2F0 dHJfcndfYmFja3dhcmRzLnBlcmwKPiBBaCwgbmljZSwgSSBsb3ZlIHBlcmwgOgoKVGhhdCB3YXMg YSBiYWQgY29weS9wYXN0ZSBvZiB0aGUgc2NyaXB0LgoKVGhlIGFjdHVhbCBzY3JpcHQgZm9yIFJX IGlzOgoKJCBjYXQgZGV2X2F0dHJfcndfYmFja3dhcmRzLnBlcmwKbG9jYWwgJC87CndoaWxlICg8 PikgewogICAgbXkgJGZpbGUgPSAkXzsKICAgIHdoaWxlICgkZmlsZSA9fiBtL1xiREVWSUNFX0FU VFJccypcKFxzKihcdyspXHMqLC9nKSB7CglteSAkdmFyID0gJDE7CglpZiAoJGZpbGUgPX4gcy9c YkRFVklDRV9BVFRSXHMqXChccyoke3Zhcn1ccyosXHMqXCg/KFxzKlNfSVJVR09ccypcfFxzKlNf SVdVU1J8XHMqU19JV1VTUlxzKlx8XHMqU19JUlVHT1xzKnxccyowNjQ0XHMqKVwpP1xzKixccypz aG93XyR7dmFyfVxzKixccypzdG9yZV8ke3Zhcn1ccypcKS9ERVZJQ0VfQVRUUl9SVygke3Zhcn0p L2cpIHsKCSAgICAkZmlsZSA9fiBzL1xic2hvd18ke3Zhcn1cYi8ke3Zhcn1fc2hvdy9nOwoJICAg ICRmaWxlID1+IHMvXGJzdG9yZV8ke3Zhcn1cYi8ke3Zhcn1fc3RvcmUvZzsKCX0KICAgIH0KICAg IHByaW50ICRmaWxlOwp9CgpUaGVyZSBhcmUgMyBkaWZmZXJlbnQgcGVybCBzY3JpcHRzIGZvciBy dywgcm8sIGFuZCB3by4KYW5kIHRoZXNlIHNjcmlwdHMsIGJlY2F1c2Ugb2YgZnVuY3Rpb24gcmVu YW1pbmcgYW5kCnBvc3NpYmxlIHJldXNlIG9mIHRoZSBvcmlnaW5hbCBmdW5jdGlvbiBuYW1lcyBi eSBvdGhlcgpzdHJpbmcgY29uY2F0ZW5hdGVkIG1hY3JvcywgY3JlYXRlIHNvbWUgYmFkIGNvbnZl cnNpb25zCnNvIHRoZXkgbmVlZCBzb21lIG1hbnVhbCBjbGVhbnVwcyB0b28uCgpQZXJoYXBzIGNv Y2NpbmVsbGUgY291bGQgZG8gYSBiZXR0ZXIgam9iIG9mIGl0LCBidXQKbGlrZWx5IHN0cmluZyBj b25jYXRlbmF0aW9uIG1hY3JvIHVzZXMgYXJlIGdvaW5nIHRvCmJlIGhhcmQgdG8gZGVhbCB3aXRo IGluIGFueSBjYXNlLgotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhl IGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRv IG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDov L3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932269AbdLTKzm (ORCPT ); Wed, 20 Dec 2017 05:55:42 -0500 Received: from smtprelay0089.hostedemail.com ([216.40.44.89]:52211 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754954AbdLTKzU (ORCPT ); Wed, 20 Dec 2017 05:55:20 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: X-HE-Tag: fifth90_2ce93c5ec6a4a X-Filterd-Recvd-Size: 5529 Message-ID: <1513767307.1234.114.camel@perches.com> Subject: Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW From: Joe Perches To: Greg Kroah-Hartman , Julia Lawall Cc: Jarkko Nikula , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Cezary Jackiewicz , Darren Hart , Andy Shevchenko , Sebastian Ott , Peter Oberparleiter , James Smart , Dick Kennedy , Zhang Rui , Eduardo Valentin , Mathias Nyman , Felipe Balbi , "Luis R. Rodriguez" , Peter Ujfalusi , Martin Schwidefsky , Heiko Carstens , David Airlie , "James E.J. Bottomley" , "Martin K. Petersen" , Jiri Slaby , Bartlomiej Zolnierkiewicz , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org Date: Wed, 20 Dec 2017 02:55:07 -0800 In-Reply-To: <20171220095926.GA24285@kroah.com> References: <20171220083403.GA27231@bitmer.com> <1513761884.1234.83.camel@perches.com> <20171220093211.GA16177@kroah.com> <1513763681.1234.101.camel@perches.com> <20171220095926.GA24285@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote: > > > Why you didn't send that patch to the sysfs maintainer is a bit odd... :) > > > > So here's an opportunity for you: > > > > The sysfs maintainer hasn't added include/linux/sysfs.h to > > the list of maintained files... > > > > DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS > > M: Greg Kroah-Hartman > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > > S: Supported > > F: Documentation/kobject.txt > > F: drivers/base/ > > F: fs/debugfs/ > > F: fs/sysfs/ > > F: include/linux/debugfs.h > > F: include/linux/kobj* > > F: lib/kobj* > > Heh, good point, but using get_maintainer.pl does put me at the top of > the list that you should be cc:ing: > > $ ./scripts/get_maintainer.pl --file include/linux/sysfs.h > Greg Kroah-Hartman (commit_signer:3/3=100%,authored:2/3=67%,added_lines:7/8=88%) > Kate Stewart (commit_signer:1/3=33%) > Thomas Gleixner (commit_signer:1/3=33%) > Philippe Ombredanne (commit_signer:1/3=33%) > Nick Desaulniers (commit_signer:1/3=33%,authored:1/3=33%,added_lines:1/8=12%,removed_lines:1/1=100%) > linux-kernel@vger.kernel.org (open list) The script I use to send patches adds --nogit --nogit-fallback to copy only listed maintainers because people that send cleanup patches don't generally like to get random patches. > > btw: there are many uses of a reversed declaration style of DEVICE_ATTR > > > > Here's another thing that could be done for more DEVICE_ATTR_ uses. > > > > === > > > > Some DEVICE_ATTR definitions use a reversed static function form from > > the typical. Convert them to use the more common macro form so it is > > easier to grep for the style. [] > > $ git grep --name-only -w DEVICE_ATTR | \ > > xargs perl -i dev_attr_rw_backwards.perl > Ah, nice, I love perl : That was a bad copy/paste of the script. The actual script for RW is: $ cat dev_attr_rw_backwards.perl local $/; while (<>) { my $file = $_; while ($file =~ m/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,/g) { my $var = $1; if ($file =~ s/\bDEVICE_ATTR\s*\(\s*${var}\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWUSR|\s*S_IWUSR\s*\|\s*S_IRUGO\s*|\s*0644\s*)\)?\s*,\s*show_${var}\s*,\s*store_${var}\s*\)/DEVICE_ATTR_RW(${var})/g) { $file =~ s/\bshow_${var}\b/${var}_show/g; $file =~ s/\bstore_${var}\b/${var}_store/g; } } print $file; } There are 3 different perl scripts for rw, ro, and wo. and these scripts, because of function renaming and possible reuse of the original function names by other string concatenated macros, create some bad conversions so they need some manual cleanups too. Perhaps coccinelle could do a better job of it, but likely string concatenation macro uses are going to be hard to deal with in any case.