All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
	linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] powerpc: Add aacraid and nvme to powernv_defconfig
Date: Sat, 23 Dec 2017 16:08:40 +1100	[thread overview]
Message-ID: <1514005720.2743.87.camel@kernel.crashing.org> (raw)
In-Reply-To: <043ac9d2-04ad-0e9a-4b01-2baae48a1e1d@ozlabs.ru>

On Sat, 2017-12-23 at 11:40 +1100, Alexey Kardashevskiy wrote:
> On 20/12/17 13:14, Benjamin Herrenschmidt wrote:
> > On Wed, 2017-12-20 at 12:59 +1100, Alexey Kardashevskiy wrote:
> > > On 20/12/17 12:51, Benjamin Herrenschmidt wrote:
> > > > These adapters can be found in a number of our systems, so let's
> > > > enable the corresponding drivers by default.
> > > > 
> > > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > > ---
> > > > --- a/arch/powerpc/configs/powernv_defconfig	2017-12-19 18:37:24.803470591 -0600
> > > > +++ b/arch/powerpc/configs/powernv_defconfig	2017-12-19 19:47:57.931952417 -0600
> > > > @@ -97,6 +97,7 @@
> > > >  CONFIG_BLK_DEV_RAM=y
> > > >  CONFIG_BLK_DEV_RAM_SIZE=65536
> > > >  CONFIG_VIRTIO_BLK=m
> > > > +CONFIG_BLK_DEV_NVME=y
> > > >  CONFIG_IDE=y
> > > >  CONFIG_BLK_DEV_IDECD=y
> > > >  CONFIG_BLK_DEV_GENERIC=y
> > > > @@ -113,6 +114,7 @@
> > > >  CONFIG_SCSI_CXGB4_ISCSI=m
> > > >  CONFIG_SCSI_BNX2_ISCSI=m
> > > >  CONFIG_BE2ISCSI=m
> > > > +CONFIG_SCSI_AACRAID=y
> > > >  CONFIG_SCSI_MPT2SAS=m
> > > >  CONFIG_SCSI_SYM53C8XX_2=m
> > > >  CONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=0
> > > > 
> > > 
> > > "y", not "m"?
> > 
> > Yes. I like my boot devices to be "y"
> 
> 
> Then rename it to powernv_benh_defconfig :) Everything else seems to cope
> well with "m" - just look above.

No. Most of the above aren't needed as boot devices on powernv systems.

If you look at IPR for example, it's Y not N.

Cheers,
Ben.

> 
> 

  reply	other threads:[~2017-12-23  5:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20  1:51 [PATCH] powerpc: Add aacraid and nvme to powernv_defconfig Benjamin Herrenschmidt
2017-12-20  1:59 ` Alexey Kardashevskiy
2017-12-20  2:14   ` Benjamin Herrenschmidt
2017-12-23  0:40     ` Alexey Kardashevskiy
2017-12-23  5:08       ` Benjamin Herrenschmidt [this message]
2018-01-17 13:30 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1514005720.2743.87.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=aik@ozlabs.ru \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.