Re: [PATCH for-next 3/3] RDMA/erdma: Fix unset QPN of GSI QP

[Zhu Yanjun <yanjun.zhu@linux.dev>]

在 2025/7/24 22:53, Boshi Yu 写道:
> The QPN of the GSI QP was not set, which may cause issues.
> Set the QPN to 1 when creating the GSI QP.

In 17.2.7 MANAGEMENT MESSAGES

"
QP1, used for the General Services Interface (GSI).
• This QP uses the Unreliable Datagram transport service.
• All traffic to and from this QP uses any VL other than VL15.
• GSI packets arriving before the current packet’s command
completes may be dropped (i.e. the minimum queue depth of
QP1 is one).
"

Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>

Zhu Yanjun

> 
> Fixes: 999a0a2e9b87 ("RDMA/erdma: Support UD QPs and UD WRs")
> Reviewed-by: Cheng Xu <chengyou@linux.alibaba.com>
> Signed-off-by: Boshi Yu <boshiyu@linux.alibaba.com>
> ---
>   drivers/infiniband/hw/erdma/erdma_verbs.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/erdma/erdma_verbs.c b/drivers/infiniband/hw/erdma/erdma_verbs.c
> index 32b11ce228dc..996860f49b2f 100644
> --- a/drivers/infiniband/hw/erdma/erdma_verbs.c
> +++ b/drivers/infiniband/hw/erdma/erdma_verbs.c
> @@ -1022,6 +1022,8 @@ int erdma_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *attrs,
>   		old_entry = xa_store(&dev->qp_xa, 1, qp, GFP_KERNEL);
>   		if (xa_is_err(old_entry))
>   			ret = xa_err(old_entry);
> +		else
> +			qp->ibqp.qp_num = 1;
>   	} else {
>   		ret = xa_alloc_cyclic(&dev->qp_xa, &qp->ibqp.qp_num, qp,
>   				      XA_LIMIT(1, dev->attrs.max_qp - 1),