All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Seth Heasley <seth.heasley@intel.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH v1] i2c: ismt: Use %pad specifier for dma_addr_t variables
Date: Thu, 28 Dec 2017 17:21:51 +0200	[thread overview]
Message-ID: <1514474511.7000.422.camel@linux.intel.com> (raw)
In-Reply-To: <20171110183358.86100-1-andriy.shevchenko@linux.intel.com>

On Fri, 2017-11-10 at 20:33 +0200, Andy Shevchenko wrote:
> ...which takes care of proper format and size of the value.

Wolfram, any comment on this?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/i2c/busses/i2c-ismt.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-
> ismt.c
> index b51adffa4841..c0d0f34d34f3 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -572,8 +572,7 @@ static int ismt_access(struct i2c_adapter *adap,
> u16 addr,
>  			return -EIO;
>  		}
>  
> -		dev_dbg(dev, " dma_addr = 0x%016llX\n",
> -			(unsigned long long)dma_addr);
> +		dev_dbg(dev, " dma_addr = %pad\n", &dma_addr);
>  
>  		desc->dptr_low = lower_32_bits(dma_addr);
>  		desc->dptr_high = upper_32_bits(dma_addr);

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-12-28 15:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10 18:33 [PATCH v1] i2c: ismt: Use %pad specifier for dma_addr_t variables Andy Shevchenko
2017-12-28 15:21 ` Andy Shevchenko [this message]
2017-12-30 23:22   ` Wolfram Sang
2017-12-31 15:48     ` Neil Horman
2018-01-03 22:00       ` Wolfram Sang
2018-01-04  2:10         ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1514474511.7000.422.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=seth.heasley@intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.