All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Alex Deucher
	<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Dmitry Rozhkov
	<dmitry.rozhkov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: amd-gfx list <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/radeon: use raw buffer printk specifier
Date: Tue, 02 Jan 2018 14:35:45 +0200	[thread overview]
Message-ID: <1514896545.7000.563.camel@linux.intel.com> (raw)
In-Reply-To: <CADnq5_M+UujKU=gwE0KGtLaXC_9ig+DoUFNwZ+v+z8+mhx2grw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Mon, 2018-01-01 at 16:12 -0500, Alex Deucher wrote:
> On Thu, Dec 21, 2017 at 5:04 AM, Dmitry Rozhkov
> <dmitry.rozhkov@linux.intel.com> wrote:
> > printk format strings accepting a single subsequent argument
> > are shorter thus easier to read.
> 
> I'm not sure I agree it's easier to read.
> IMHO, it's somewhat less
> clear what's going on, 

If you check how many times %*ph is used in the kernel... Or then you
may concern about entire bunch of %p extensions in the kernel.

Anyway, main rationale I think is a stack use and performance.

But it's still about debug messages in this case, and in particular only
about 3 bytes (btw, if needed it might be easily expanded for up to 64
bytes or even with run-time adjusted length).

> but I don't have a particularly strong opinion
> either way.  Applied.

Thanks.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      parent reply	other threads:[~2018-01-02 12:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 10:04 [PATCH] drm/radeon: use raw buffer printk specifier Dmitry Rozhkov
     [not found] ` <20171221100453.6203-1-dmitry.rozhkov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-12-28 15:26   ` Andy Shevchenko
2018-01-01 21:12   ` Alex Deucher
     [not found]     ` <CADnq5_M+UujKU=gwE0KGtLaXC_9ig+DoUFNwZ+v+z8+mhx2grw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-02 12:35       ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1514896545.7000.563.camel@linux.intel.com \
    --to=andriy.shevchenko-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=dmitry.rozhkov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.