From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline Date: Tue, 2 Jan 2018 15:11:42 +0000 Message-ID: <1514905900.4242.4.camel@wdc.com> References: <1514386305-7402-1-git-send-email-Julia.Lawall@lip6.fr> <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com> <1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <393EABA14D4C8A408D6445306BCE9BFE@namprd04.prod.outlook.com> Sender: kernel-janitors-owner@vger.kernel.org To: "rpeterso@redhat.com" , "julia.lawall@lip6.fr" Cc: "kernel-janitors@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jolsa@redhat.com" , "linux-media@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , "namhyung@kernel.org" , "linux-scsi@vger.kernel.org" , "esc.storagedev@microsemi.com" , "dri-devel@lists.freedesktop.org" , "alexander.shishkin@linux.intel.com" , "dev@openvswitch.org" , "netdev@vger.kernel.org" , linux-arm-kernel@li List-Id: amd-gfx.lists.freedesktop.org T24gVHVlLCAyMDE4LTAxLTAyIGF0IDE1OjAwICswMTAwLCBKdWxpYSBMYXdhbGwgd3JvdGU6DQo+ IE9uIFR1ZSwgMiBKYW4gMjAxOCwgQm9iIFBldGVyc29uIHdyb3RlOg0KPiA+IC0tLS0tIE9yaWdp bmFsIE1lc3NhZ2UgLS0tLS0NCj4gPiA+IC0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0NCj4g PiA+DQo+ID4gU3RpbGwsIHRoZSBHRlMyIGFuZCBETE0gY29kZSBoYXMgYSBwbGV0aG9yYSBvZiBi cm9rZW4tdXAgcHJpbnRrIG1lc3NhZ2VzLA0KPiA+IGFuZCBJIGRvbid0IGxpa2UgdGhlIHRob3Vn aHQgb2YgcmUtY29tYmluaW5nIHRoZW0gYWxsLg0KPiANCj4gQWN0dWFsbHksIHRoZSBwb2ludCBv ZiB0aGUgcGF0Y2ggd2FzIHRvIHJlbW92ZSB0aGUgdW5uZWNlc3NhcnkgXG4gYXQgdGhlDQo+IGVu ZCBvZiB0aGUgc3RyaW5nLCBiZWNhdXNlIGxvZ19wcmludCB3aWxsIGFkZCBhbm90aGVyIG9uZS4g IElmIHlvdSBwcmVmZXINCj4gdG8ga2VlcCB0aGUgc3RyaW5nIGJyb2tlbiB1cCwgSSBjYW4gcmVz ZW5kIHRoZSBwYXRjaCBpbiB0aGF0IGZvcm0sIGJ1dA0KPiB3aXRob3V0IHRoZSB1bm5lY2Vzc2Fy eSBcbi4NCg0KUGxlYXNlIGNvbWJpbmUgYW55IHVzZXItdmlzaWJsZSBzdHJpbmdzIGludG8gYSBz aW5nbGUgbGluZSBmb3Igd2hpY2ggdGhlDQp1bm5lZWRlZCBuZXdsaW5lIGlzIGRyb3BwZWQgc2lu Y2UgdGhlc2Ugc3RyaW5ncyBhcmUgbW9kaWZpZWQgYW55d2F5IGJ5DQp5b3VyIHBhdGNoLg0KDQpU aGFua3MsDQoNCkJhcnQu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Date: Tue, 2 Jan 2018 15:11:42 +0000 Subject: [Cluster-devel] [PATCH 00/12] drop unneeded newline In-Reply-To: References: <1514386305-7402-1-git-send-email-Julia.Lawall@lip6.fr> <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com> <1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com> Message-ID: <1514905900.4242.4.camel@wdc.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > On Tue, 2 Jan 2018, Bob Peterson wrote: > > ----- Original Message ----- > > > ----- Original Message ----- > > > > > Still, the GFS2 and DLM code has a plethora of broken-up printk messages, > > and I don't like the thought of re-combining them all. > > Actually, the point of the patch was to remove the unnecessary \n at the > end of the string, because log_print will add another one. If you prefer > to keep the string broken up, I can resend the patch in that form, but > without the unnecessary \n. Please combine any user-visible strings into a single line for which the unneeded newline is dropped since these strings are modified anyway by your patch. Thanks, Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Date: Tue, 02 Jan 2018 15:11:42 +0000 Subject: Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline Message-Id: <1514905900.4242.4.camel@wdc.com> List-Id: References: <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com> In-Reply-To: <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dccp@vger.kernel.org T24gVHVlLCAyMDE4LTAxLTAyIGF0IDE1OjAwICswMTAwLCBKdWxpYSBMYXdhbGwgd3JvdGU6DQo+ IE9uIFR1ZSwgMiBKYW4gMjAxOCwgQm9iIFBldGVyc29uIHdyb3RlOg0KPiA+IC0tLS0tIE9yaWdp bmFsIE1lc3NhZ2UgLS0tLS0NCj4gPiA+IC0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0NCj4g PiA+DQo+ID4gU3RpbGwsIHRoZSBHRlMyIGFuZCBETE0gY29kZSBoYXMgYSBwbGV0aG9yYSBvZiBi cm9rZW4tdXAgcHJpbnRrIG1lc3NhZ2VzLA0KPiA+IGFuZCBJIGRvbid0IGxpa2UgdGhlIHRob3Vn aHQgb2YgcmUtY29tYmluaW5nIHRoZW0gYWxsLg0KPiANCj4gQWN0dWFsbHksIHRoZSBwb2ludCBv ZiB0aGUgcGF0Y2ggd2FzIHRvIHJlbW92ZSB0aGUgdW5uZWNlc3NhcnkgXG4gYXQgdGhlDQo+IGVu ZCBvZiB0aGUgc3RyaW5nLCBiZWNhdXNlIGxvZ19wcmludCB3aWxsIGFkZCBhbm90aGVyIG9uZS4g IElmIHlvdSBwcmVmZXINCj4gdG8ga2VlcCB0aGUgc3RyaW5nIGJyb2tlbiB1cCwgSSBjYW4gcmVz ZW5kIHRoZSBwYXRjaCBpbiB0aGF0IGZvcm0sIGJ1dA0KPiB3aXRob3V0IHRoZSB1bm5lY2Vzc2Fy eSBcbi4NCg0KUGxlYXNlIGNvbWJpbmUgYW55IHVzZXItdmlzaWJsZSBzdHJpbmdzIGludG8gYSBz aW5nbGUgbGluZSBmb3Igd2hpY2ggdGhlDQp1bm5lZWRlZCBuZXdsaW5lIGlzIGRyb3BwZWQgc2lu Y2UgdGhlc2Ugc3RyaW5ncyBhcmUgbW9kaWZpZWQgYW55d2F5IGJ5DQp5b3VyIHBhdGNoLg0KDQpU aGFua3MsDQoNCkJhcnQu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Date: Tue, 02 Jan 2018 15:11:42 +0000 Subject: Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline Message-Id: <1514905900.4242.4.camel@wdc.com> List-Id: References: <1514386305-7402-1-git-send-email-Julia.Lawall@lip6.fr> <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com> <1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "rpeterso@redhat.com" , "julia.lawall@lip6.fr" Cc: "kernel-janitors@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jolsa@redhat.com" , "linux-media@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , "namhyung@kernel.org" , "linux-scsi@vger.kernel.org" , "esc.storagedev@microsemi.com" , "dri-devel@lists.freedesktop.org" , "alexander.shishkin@linux.intel.com" , "dev@openvswitch.org" , "netdev@vger.kernel.org" , linux-arm-kernel@li T24gVHVlLCAyMDE4LTAxLTAyIGF0IDE1OjAwICswMTAwLCBKdWxpYSBMYXdhbGwgd3JvdGU6DQo+ IE9uIFR1ZSwgMiBKYW4gMjAxOCwgQm9iIFBldGVyc29uIHdyb3RlOg0KPiA+IC0tLS0tIE9yaWdp bmFsIE1lc3NhZ2UgLS0tLS0NCj4gPiA+IC0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0NCj4g PiA+DQo+ID4gU3RpbGwsIHRoZSBHRlMyIGFuZCBETE0gY29kZSBoYXMgYSBwbGV0aG9yYSBvZiBi cm9rZW4tdXAgcHJpbnRrIG1lc3NhZ2VzLA0KPiA+IGFuZCBJIGRvbid0IGxpa2UgdGhlIHRob3Vn aHQgb2YgcmUtY29tYmluaW5nIHRoZW0gYWxsLg0KPiANCj4gQWN0dWFsbHksIHRoZSBwb2ludCBv ZiB0aGUgcGF0Y2ggd2FzIHRvIHJlbW92ZSB0aGUgdW5uZWNlc3NhcnkgXG4gYXQgdGhlDQo+IGVu ZCBvZiB0aGUgc3RyaW5nLCBiZWNhdXNlIGxvZ19wcmludCB3aWxsIGFkZCBhbm90aGVyIG9uZS4g IElmIHlvdSBwcmVmZXINCj4gdG8ga2VlcCB0aGUgc3RyaW5nIGJyb2tlbiB1cCwgSSBjYW4gcmVz ZW5kIHRoZSBwYXRjaCBpbiB0aGF0IGZvcm0sIGJ1dA0KPiB3aXRob3V0IHRoZSB1bm5lY2Vzc2Fy eSBcbi4NCg0KUGxlYXNlIGNvbWJpbmUgYW55IHVzZXItdmlzaWJsZSBzdHJpbmdzIGludG8gYSBz aW5nbGUgbGluZSBmb3Igd2hpY2ggdGhlDQp1bm5lZWRlZCBuZXdsaW5lIGlzIGRyb3BwZWQgc2lu Y2UgdGhlc2Ugc3RyaW5ncyBhcmUgbW9kaWZpZWQgYW55d2F5IGJ5DQp5b3VyIHBhdGNoLg0KDQpU aGFua3MsDQoNCkJhcnQu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart.VanAssche@wdc.com (Bart Van Assche) Date: Tue, 2 Jan 2018 15:11:42 +0000 Subject: [Cluster-devel] [PATCH 00/12] drop unneeded newline In-Reply-To: References: <1514386305-7402-1-git-send-email-Julia.Lawall@lip6.fr> <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com> <1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com> Message-ID: <1514905900.4242.4.camel@wdc.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > On Tue, 2 Jan 2018, Bob Peterson wrote: > > ----- Original Message ----- > > > ----- Original Message ----- > > > > > Still, the GFS2 and DLM code has a plethora of broken-up printk messages, > > and I don't like the thought of re-combining them all. > > Actually, the point of the patch was to remove the unnecessary \n at the > end of the string, because log_print will add another one. If you prefer > to keep the string broken up, I can resend the patch in that form, but > without the unnecessary \n. Please combine any user-visible strings into a single line for which the unneeded newline is dropped since these strings are modified anyway by your patch. Thanks, Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from esa4.hgst.iphmx.com ([216.71.154.42]:10089 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753573AbeABPLq (ORCPT ); Tue, 2 Jan 2018 10:11:46 -0500 From: Bart Van Assche To: "rpeterso@redhat.com" , "julia.lawall@lip6.fr" CC: "kernel-janitors@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jolsa@redhat.com" , "linux-media@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , "namhyung@kernel.org" , "linux-scsi@vger.kernel.org" , "esc.storagedev@microsemi.com" , "dri-devel@lists.freedesktop.org" , "alexander.shishkin@linux.intel.com" , "dev@openvswitch.org" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "dccp@vger.kernel.org" , "cluster-devel@redhat.com" , "linux-ext4@vger.kernel.org" Subject: Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline Date: Tue, 2 Jan 2018 15:11:42 +0000 Message-ID: <1514905900.4242.4.camel@wdc.com> References: <1514386305-7402-1-git-send-email-Julia.Lawall@lip6.fr> <1878806802.2632123.1514901158666.JavaMail.zimbra@redhat.com> <1019862289.2632779.1514901387442.JavaMail.zimbra@redhat.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <393EABA14D4C8A408D6445306BCE9BFE@namprd04.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org List-ID: T24gVHVlLCAyMDE4LTAxLTAyIGF0IDE1OjAwICswMTAwLCBKdWxpYSBMYXdhbGwgd3JvdGU6DQo+ IE9uIFR1ZSwgMiBKYW4gMjAxOCwgQm9iIFBldGVyc29uIHdyb3RlOg0KPiA+IC0tLS0tIE9yaWdp bmFsIE1lc3NhZ2UgLS0tLS0NCj4gPiA+IC0tLS0tIE9yaWdpbmFsIE1lc3NhZ2UgLS0tLS0NCj4g PiA+DQo+ID4gU3RpbGwsIHRoZSBHRlMyIGFuZCBETE0gY29kZSBoYXMgYSBwbGV0aG9yYSBvZiBi cm9rZW4tdXAgcHJpbnRrIG1lc3NhZ2VzLA0KPiA+IGFuZCBJIGRvbid0IGxpa2UgdGhlIHRob3Vn aHQgb2YgcmUtY29tYmluaW5nIHRoZW0gYWxsLg0KPiANCj4gQWN0dWFsbHksIHRoZSBwb2ludCBv ZiB0aGUgcGF0Y2ggd2FzIHRvIHJlbW92ZSB0aGUgdW5uZWNlc3NhcnkgXG4gYXQgdGhlDQo+IGVu ZCBvZiB0aGUgc3RyaW5nLCBiZWNhdXNlIGxvZ19wcmludCB3aWxsIGFkZCBhbm90aGVyIG9uZS4g IElmIHlvdSBwcmVmZXINCj4gdG8ga2VlcCB0aGUgc3RyaW5nIGJyb2tlbiB1cCwgSSBjYW4gcmVz ZW5kIHRoZSBwYXRjaCBpbiB0aGF0IGZvcm0sIGJ1dA0KPiB3aXRob3V0IHRoZSB1bm5lY2Vzc2Fy eSBcbi4NCg0KUGxlYXNlIGNvbWJpbmUgYW55IHVzZXItdmlzaWJsZSBzdHJpbmdzIGludG8gYSBz aW5nbGUgbGluZSBmb3Igd2hpY2ggdGhlDQp1bm5lZWRlZCBuZXdsaW5lIGlzIGRyb3BwZWQgc2lu Y2UgdGhlc2Ugc3RyaW5ncyBhcmUgbW9kaWZpZWQgYW55d2F5IGJ5DQp5b3VyIHBhdGNoLg0KDQpU aGFua3MsDQoNCkJhcnQu