From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alistair Francis <alistair.francis@xilinx.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] glib-2.0: Remove python3 modules when building for mingw
Date: Wed, 03 Jan 2018 10:54:59 +0000 [thread overview]
Message-ID: <1514976899.5525.120.camel@linuxfoundation.org> (raw)
In-Reply-To: <20180102224935.23756-1-alistair.francis@xilinx.com>
On Tue, 2018-01-02 at 14:49 -0800, Alistair Francis wrote:
> Commit "glib-2.0: Add python3 modules required by gdbus-codegen"
> (26af3b4b33a34d7e53059b07236f9d5aae5e004a) broke the MinGW build of
> QEMU. To fix the build remove the python3 RDEPENDS for gdbus-codegen
> when targeting mingw.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
> meta/recipes-core/glib-2.0/glib.inc | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-
> core/glib-2.0/glib.inc
> index fbc655a012..f8e803a90a 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -121,6 +121,12 @@ RDEPENDS_${PN}-codegen += "\
> python3-xml \
> "
>
> +RDEPENDS_${PN}-codegen_remove_mingw32 = "\
> + python3 \
> + python3-distutils \
> + python3-xml \
> + "
> +
> RDEPENDS_${PN}-ptest += "\
> dbus \
> gnome-desktop-testing \
I have pretty strong feelings that we shouldn't be using remove like
this, or duplicating data. Its susceptible to breakage when one value
changes and the other does not. Can you rework this so it doesn't use
remove, or duplicate data?
In case its not clear, you can do something like:
CODEGEN_PYTHON_RDEPENDS = "python3 python3-distutils python3-xml"
CODEGEN_PYTHON_RDEPENDS_mingw32 = ""
RDEPENDS_${PN}-codegen += "${CODEGEN_PYTHON_RDEPENDS}"
which is much more maintainable.
Cheers,
Richard
next prev parent reply other threads:[~2018-01-03 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 22:49 [PATCH] glib-2.0: Remove python3 modules when building for mingw Alistair Francis
2018-01-03 10:54 ` Richard Purdie [this message]
2018-01-03 19:48 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1514976899.5525.120.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alistair.francis@xilinx.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.