Re: [PATCH, resend 4/4] IB/srp: Add RDMA/CM support

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

On Fri, 2018-01-05 at 18:12 +0000, Bart Van Assche wrote:
> On Fri, 2018-01-05 at 13:06 -0500, Doug Ledford wrote:
> > No, the target code is likewise clueless about namespaces.  I suspect
> > (although I haven't looked) that the target code's Add RDMACM support
> > patch will have the same problem.
> 
> Hello Doug,
> 
> The target code already allows to configure ACL (access control lists) that
> control which initiator systems are allowed to log in and which ones not. Are
> you sure that it will be valuable to add network namespace support to the
> RDMA/CM code in the SRP target driver?

I haven't really thought about it much.  My comment wasn't that I
thought it should be implemented, just that my quick grep of init_net in
the drivers/infiniband directory showed me that the srpt driver doesn't
distinguish any namespaces (while the isert driver does), so I suspect
adding rdmacm support will add a new init_net usage.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]