Re: [selftest][PATCH V1 0/5] QA: Extend unit tests for event module

[Richard Purdie <richard.purdie@linuxfoundation.org>]

Hi Jair,

I finally got to this. Its basically ok but I don't like the data
attribute being set to "None". I've dropped that bit and will remove
the getCfg and setCfg pieces instead as I don't think we're using them
anywhere. I have that queued in master-next.

Sorry about the delay in getting to this.

Cheers,

Richard



On Fri, 2017-12-08 at 15:24 -0600, Jair Gonzalez wrote:
> Hello,
> 
> Have you been able to review this series of patches? It's being
> tracked on
> bug 10773.
> 
> Please let me know if you have any doubts or comments about it.
> 
> Regards,
> Jair Gonzalez
> 
> > 
> > -----Original Message-----
> > From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-
> > devel-
> > bounces@lists.openembedded.org] On Behalf Of Jair Gonzalez
> > Sent: Thursday, August 17, 2017 3:41 PM
> > To: bitbake-devel@lists.openembedded.org
> > Subject: [bitbake-devel] [selftest][PATCH V1 0/5] QA: Extend unit
> > tests
> for event
> > 
> > module
> > 
> > Included on V1:
> > 
> >   This patch-set extends the unit test module for bitbake event
> >   including increased coverage for event filtering features and
> >   testing of public interfaces of event and helper classes. It
> >   also includes two small fixes for issues found during the unit
> >   test development.
> > 
> > [YOCTO #10773]
> > 
> > The following changes since commit
> > 6016ec177af2406cacfeb3276dfcb8bfc3df8fce:
> > 
> >   poky.conf: Enable vulkan by default (2017-08-16 00:04:39 +0100)
> > 
> > are available in the git repository at:
> > 
> >   git://git.yoctoproject.org/poky-contrib jairglez/bbevent_extended
> >   http://git.yoctoproject.org/cgit.cgi/poky-
> > contrib/log/?h=jairglez/bbevent_extended
> > 
> > Jair Gonzalez (5):
> >   bitbake: tests: Include tests for event filtering features
> >   bitbake: tests: Add test for bb.event.worker_fire
> >   bitbake: tests: Remove empty assignments from event tests
> >   bitbake: tests: Initialize data attribute on BuildBase event
> >   bitbake: tests: Add event classes test class
> > 
> >  lib/bb/event.py       |   1 +
> >  lib/bb/tests/event.py | 646
> > +++++++++++++++++++++++++++++++++++++++++++++++++-
> >  2 files changed, 634 insertions(+), 13 deletions(-)
> > 
> > --
> > 2.7.4
> > 
> > --
> > _______________________________________________
> > bitbake-devel mailing list
> > bitbake-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/bitbake-devel