All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yves-Alexis Perez <corsac@debian.org>
To: Hannes Reinecke <hare@suse.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCHv2] libsas: Check for completed commands before calling lldd_abort_task()
Date: Mon, 08 Jan 2018 18:11:36 +0100	[thread overview]
Message-ID: <1515431496.3305.62.camel@debian.org> (raw)
In-Reply-To: <1515413086-34256-1-git-send-email-hare@suse.de>

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

On Mon, 2018-01-08 at 13:04 +0100, Hannes Reinecke wrote:
> The abort handler might be racing with command completion, so the
> task might already be NULL by the time the abort handler is called.

Hi,

I tried the patch on top of 4.15-rc7 (and without the revert of 90965761). I
don't have the NULL pointer deref anymore, but the box timeouts after SCSI
init. It's not completely dead, but I don't have any meaningful log from the
kernel.

Regards,
-- 
Yves-Alexis

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-01-08 17:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08 12:04 [PATCHv2] libsas: Check for completed commands before calling lldd_abort_task() Hannes Reinecke
2018-01-08 17:11 ` Yves-Alexis Perez [this message]
2018-01-09  9:30   ` Hannes Reinecke
2018-01-09 14:13     ` Yves-Alexis Perez
2018-01-09  4:09 ` Jason Yan
2018-01-09  7:34   ` Hannes Reinecke
2018-01-09  9:04     ` Jason Yan
2018-01-09  9:27       ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515431496.3305.62.camel@debian.org \
    --to=corsac@debian.org \
    --cc=hare@suse.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.