From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH net-next v2 1/6] net: Fix netdev_WARN_ONCE macro Date: Mon, 08 Jan 2018 18:42:01 -0800 Message-ID: <1515465721.9619.78.camel@perches.com> References: <1515319720-18428-1-git-send-email-galp@mellanox.com> <1515319720-18428-2-git-send-email-galp@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Tariq Toukan , Saeed Mahameed To: Gal Pressman , "David S. Miller" Return-path: Received: from smtprelay0098.hostedemail.com ([216.40.44.98]:45635 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754207AbeAICmE (ORCPT ); Mon, 8 Jan 2018 21:42:04 -0500 In-Reply-To: <1515319720-18428-2-git-send-email-galp@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 2018-01-07 at 12:08 +0200, Gal Pressman wrote: > netdev_WARN_ONCE is broken (whoops..), this fix will remove the > unnecessary "condition" parameter, add the missing comma and change > "arg" to "args". > > Fixes: 375ef2b1f0d0 ("net: Introduce netdev_*_once functions") > Signed-off-by: Gal Pressman > Reviewed-by: Saeed Mahameed > --- > include/linux/netdevice.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 352066e..5ff1ef9 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -4407,8 +4407,8 @@ do { \ > WARN(1, "netdevice: %s%s\n" format, netdev_name(dev), \ > netdev_reg_state(dev), ##args) > > -#define netdev_WARN_ONCE(dev, condition, format, arg...) \ > - WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev) \ > +#define netdev_WARN_ONCE(dev, format, args...) \ > + WARN_ONCE(1, "netdevice: %s%s\n" format, netdev_name(dev), \ You sure you want the newline before the format? > netdev_reg_state(dev), ##args) > > /* netif printk helpers, similar to netdev_printk */