From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix using BIT_ULL() vs. BIT() for power domain masks
Date: Tue, 09 Jan 2018 16:40:15 +0200 [thread overview]
Message-ID: <1515508815.8280.2.camel@linux.intel.com> (raw)
In-Reply-To: <20180109122040.19425-1-imre.deak@intel.com>
On Tue, 2018-01-09 at 14:20 +0200, Imre Deak wrote:
> The power domain masks are 64 bit wide, so we need BIT_ULL() when
> setting bits in them, these ones were missed during converting from 32
> to 64 bit masks. All 3 enums are <32 atm, so this didn't cause a real
> problem.
>
> Fixes: d8fc70b7367b ("drm/i915: Make power domain masks 64 bit long")
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Those are some strange misses, surrounded by code that was touched.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-09 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 12:20 [PATCH] drm/i915: Fix using BIT_ULL() vs. BIT() for power domain masks Imre Deak
2018-01-09 13:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-01-09 14:56 ` Imre Deak
2018-01-09 13:36 ` [PATCH] " Chris Wilson
2018-01-09 14:40 ` Joonas Lahtinen [this message]
2018-01-09 15:56 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515508815.8280.2.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.