From: Lyude Paul <lyude@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Wim Van Sebroeck" <wim@iguana.be>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
"Zoltán Böszörményi" <zboszor@pr.hu>
Subject: Re: [11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware
Date: Tue, 09 Jan 2018 19:04:25 -0500 [thread overview]
Message-ID: <1515542665.3456.0.camel@redhat.com> (raw)
In-Reply-To: <20180109233703.GD26819@roeck-us.net>
How exactly did you go about enabling the Super-IO watchdog on your MSI board?
This is an MSI A320M that I'm trying to make work here
On Tue, 2018-01-09 at 15:37 -0800, Guenter Roeck wrote:
> Hi,
>
> On Tue, Jan 09, 2018 at 05:58:07PM -0500, Lyude Paul wrote:
> > Hi! I'm the one from the Fedora bugzilla who said they'd help review these
> > patches. I might end up responding to this with a real review comment
> > after
> > this message, but first:
> >
> > mind cc'ing me future versions of this patchset and also, is there any way
> > you
>
> Sure.
>
> > know of that one could figure out whether or not the sp5100_tco wdt is
> > actually disabled by the OEM on a board? I tried testing these patches
> > with my
>
> That is what the code is trying to do today.
>
> > system and it appears to be convinced that it's disabled on my system, but
> > I'm
> > hoping something in this patch is just broken…
> >
>
> I tested the driver on three different boards. MSI B350M MORTAR,
> MSI B350 TOMAHAWK, and Gigabyte AB350M-Gaming 3. CPU is Ryzen 1700X
> on all boards.
>
> On the MSI boards, the watchdog is reported as disabled. Enabling it
> and letting it expire does not have an effect. I am using the Super-IO
> watchdog instead on those boards (and it works).
>
> On the Gigabyte board, the watchdog is reported as enabled, and it works
> (and the watchdog on the Super-IO chips does not work).
>
> Feel free to play with the driver. Maybe there is a means to enable the
> watchdog if it is disabled. Unfortunately, I was unable to figure out how
> to do it, so I thought it is better to report the fact and not instantiate
> the watchdog if it doesn't work.
>
> Hope this helps,
> Guenter
--
Cheers,
Lyude Paul
next prev parent reply other threads:[~2018-01-10 0:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-24 21:04 [PATCH 00/12] watchdog: sp5100_tco: Various improvements Guenter Roeck
2017-12-24 21:04 ` [PATCH 01/12] watchdog: sp5100_tco: Always use SP5100_IO_PM_{INDEX_REG,DATA_REG} Guenter Roeck
2017-12-24 21:04 ` [PATCH 02/12] watchdog: sp5100_tco: Fix watchdog disable bit Guenter Roeck
2017-12-24 21:04 ` [PATCH 03/12] watchdog: sp5100_tco: Use request_muxed_region where possible Guenter Roeck
2018-01-16 19:44 ` [03/12] " Lyude Paul
2018-01-16 20:16 ` Guenter Roeck
2017-12-24 21:04 ` [PATCH 04/12] watchdog: sp5100_tco: Use standard error codes Guenter Roeck
2018-01-16 19:46 ` [04/12] " Lyude Paul
2017-12-24 21:04 ` [PATCH 05/12] watchdog: sp5100_tco: Clean up sp5100_tco_setupdevice Guenter Roeck
2018-01-16 19:55 ` [05/12] " Lyude Paul
2018-01-16 20:22 ` Guenter Roeck
2018-01-17 1:28 ` Guenter Roeck
2017-12-24 21:04 ` [PATCH 06/12] watchdog: sp5100_tco: Match PCI device early Guenter Roeck
2018-01-16 19:58 ` [06/12] " Lyude Paul
2017-12-24 21:04 ` [PATCH 07/12] watchdog: sp5100_tco: Use dev_ print functions where possible Guenter Roeck
2018-01-16 20:00 ` [07/12] " Lyude Paul
2017-12-24 21:04 ` [PATCH 08/12] watchdog: sp5100_tco: Clean up function and variable names Guenter Roeck
2018-01-16 20:05 ` [08/12] " Lyude Paul
2017-12-24 21:04 ` [PATCH 09/12] watchdog: sp5100_tco: Convert to use watchdog subsystem Guenter Roeck
2017-12-24 21:04 ` [PATCH 10/12] watchdog: sp5100_tco: Use bit operations Guenter Roeck
2017-12-24 21:04 ` [PATCH 11/12] watchdog: sp5100-tco: Abort if watchdog is disabled by hardware Guenter Roeck
2018-01-09 22:58 ` [11/12] " Lyude Paul
2018-01-09 23:37 ` Guenter Roeck
2018-01-09 23:58 ` Gabriel C
2018-01-10 0:05 ` Guenter Roeck
2018-01-10 1:26 ` Gabriel C
2018-01-10 2:09 ` Guenter Roeck
2018-01-10 2:41 ` Gabriel C
2018-01-10 5:02 ` Guenter Roeck
2018-01-10 0:04 ` Lyude Paul [this message]
2018-01-10 0:11 ` Guenter Roeck
2018-01-10 0:30 ` Lyude Paul
2017-12-24 21:04 ` [PATCH 12/12] watchdog: sp5100_tco: Add support for recent FCH versions Guenter Roeck
2018-01-04 12:01 ` Boszormenyi Zoltan
2018-01-04 19:21 ` Guenter Roeck
2018-01-10 8:34 ` Boszormenyi Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515542665.3456.0.camel@redhat.com \
--to=lyude@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@iguana.be \
--cc=zboszor@pr.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.