From: Patrick Ohly <patrick.ohly@intel.com>
To: Ingo Flaschberger <ingo.flaschberger@gmail.com>, yocto@yoctoproject.org
Subject: Re: [meta-swupd][PATCH 1/1] bundles.py: allow username/password encoded in URLs
Date: Wed, 10 Jan 2018 10:58:51 +0100 [thread overview]
Message-ID: <1515578331.6718.20.camel@intel.com> (raw)
In-Reply-To: <4e7d3d4d-12b5-3e5c-94be-084fbbc22daf@gmail.com>
On Tue, 2018-01-09 at 19:28 +0100, Ingo Flaschberger wrote:
> Dear Patrick,
>
> it works if you replace:
> manager.add_password(None, parsed_url, parsed_url.username,
> parsed_url.password)
> with:
> manager.add_password(None, new_url, parsed_url.username,
> parsed_url.password)
I assume this works on top of my proposal. To avoid such ambiguity and
the risk that something gets merged that is still incomplete, please
post the entire patch as tested by you. The right way would be "git
send-email", but I can also take "git diff" attached to an email.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next prev parent reply other threads:[~2018-01-10 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 15:04 [meta-swupd] allow username/password encoded in SWUPD_VERSION_URL and SWUPD_CONTENT_URL Ingo Flaschberger
2017-03-24 9:04 ` Patrick Ohly
2017-03-25 20:14 ` Ingo Flaschberger
2017-12-20 15:50 ` Patrick Ohly
2017-12-20 15:50 ` [meta-swupd][PATCH 1/1] bundles.py: allow username/password encoded in URLs Patrick Ohly
2017-12-20 23:18 ` Ingo Flaschberger
2018-01-09 16:57 ` Patrick Ohly
2018-01-09 18:28 ` Ingo Flaschberger
2018-01-10 9:58 ` Patrick Ohly [this message]
2018-02-24 23:31 ` Ingo Flaschberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515578331.6718.20.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=ingo.flaschberger@gmail.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.