All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Safonov <dima@arista.com>
To: Eric Dumazet <edumazet@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	0x7f454c46@gmail.com, Andrew Morton <akpm@linux-foundation.org>,
	David Miller <davem@davemloft.net>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Hannes Frederic Sowa <hannes@stressinduktion.org>,
	Ingo Molnar <mingo@kernel.org>,
	"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Paolo Abeni <pabeni@redhat.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Radu Rendec <rrendec@arista.com>, Rik van Riel <riel@redhat.com>,
	Stanislaw Gruszka <sgruszka@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Wanpeng Li <wanpeng.li@hotmail.com>
Subject: Re: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context
Date: Wed, 10 Jan 2018 21:48:00 +0000	[thread overview]
Message-ID: <1515620880.3350.44.camel@arista.com> (raw)
In-Reply-To: <CANn89iK3M97MN0Pf3nXb+UAqqhUWOdSthHRBTYCwP75Ax_hO8Q@mail.gmail.com>

On Tue, 2018-01-09 at 10:02 -0800, Eric Dumazet wrote:
> On Tue, Jan 9, 2018 at 5:36 AM, Dmitry Safonov <dima@arista.com>
> wrote:
> > Warning: Not merge-ready
> > 
> > I. Current workflow of ksoftirqd.
> >   Softirqs are processed in the context of ksoftirqd iff they are
> >   being raised very frequently. How it works:
> >   do_softirq() and invoke_softirq() deffer pending softirq iff
> > 
> 
> ...
> 
> > 
> >   Note, that I tested in VMs and I've found that if I produce more
> >   hw irqs on the host, than the results for master are not that
> >   dramatically bad, but still much worse then with RFC.
> >   By that reason I have qualms if my test's results are correct.
> 
> Note that deferring all NET RX/TX to ksoftirqd is going to
> dramatically hurt tail latencies.
> 
> You really should test with RPC like workloads (netperf -t TCP_RR)
> and
> hundred of threads per cpu :/

Yeah, thanks for the reply, will give that a shot.

> 
> It seems we are going to revert/adapt 4cd13c21b2 , not defer more
> stuff to ksoftirqd.

Hmm, what if we use some other logic for deferring/non-deferring
like checking how many softirqs where serviced during process's
timeslice and decide if proceed with __do_softirq() or defer it
not to starve a task? Might that make sense?

-- 
Thanks,
             Dmitry

  reply	other threads:[~2018-01-10 21:48 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 13:36 [RFC 0/2] Net softirq deferring to ksoftirqd Dmitry Safonov
2018-01-09 13:36 ` [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context Dmitry Safonov
2018-01-09 16:03   ` Frederic Weisbecker
2018-01-10 21:20     ` Dmitry Safonov
2018-01-09 18:02   ` Eric Dumazet
2018-01-10 21:48     ` Dmitry Safonov [this message]
2018-01-11  2:13       ` Linus Torvalds
2018-01-11  3:22         ` Frederic Weisbecker
2018-01-11  4:19           ` Linus Torvalds
2018-01-11  4:44             ` Frederic Weisbecker
2018-01-11 14:31               ` Dmitry Safonov
2018-01-11 16:20                 ` Eric Dumazet
2018-01-11 16:32                   ` Peter Zijlstra
2018-01-11 16:38                     ` David Miller
2018-01-11 16:43                       ` Peter Zijlstra
2018-01-11 18:48                     ` Linus Torvalds
2018-01-11 19:15                       ` Eric Dumazet
2018-01-11 19:43                         ` Linus Torvalds
2018-01-11 19:48                           ` Eric Dumazet
2018-01-11 20:03                             ` Linus Torvalds
2018-01-11 20:16                               ` Eric Dumazet
2018-01-11 20:22                                 ` Linus Torvalds
2018-01-11 20:34                                   ` Dmitry Safonov
2018-01-11 20:37                                     ` Eric Dumazet
2018-01-11 20:40                                     ` Linus Torvalds
2018-01-11 20:46                                       ` Dmitry Safonov
2018-01-11 20:53                                         ` Eric Dumazet
2018-01-11 21:13                                           ` Dmitry Safonov
2018-01-12  5:41                                             ` Frederic Weisbecker
2018-01-12  5:23                                   ` Mike Galbraith
2018-01-12 10:13                                     ` Peter Zijlstra
2018-01-12 17:26                                       ` Linus Torvalds
2018-01-12 17:44                                         ` Mike Galbraith
2018-01-12 17:51                                           ` Linus Torvalds
2018-01-12 18:15                                             ` Mike Galbraith
2018-01-12 18:44                                               ` Mike Galbraith
2018-01-17 20:30                                                 ` David Miller
2018-01-17 21:06                                                   ` Linus Torvalds
2018-01-17 21:49                                                     ` David Miller
2018-01-17 21:54                                                       ` Thomas Gleixner
2018-01-17 21:58                                                         ` Linus Torvalds
2018-01-17 22:00                                                           ` Thomas Gleixner
2018-01-17 22:02                                                             ` Eric Dumazet
2018-01-17 22:24                                                               ` David Miller
2018-01-17 22:54                                                                 ` Thomas Gleixner
2018-02-06 16:56                                                                 ` Sebastian Andrzej Siewior
2018-02-13 16:36                                                                   ` Thomas Gleixner
2018-01-17 21:54                                                       ` Linus Torvalds
2018-01-17 21:58                                                         ` Thomas Gleixner
2018-01-12 19:28                                             ` Thomas Gleixner
2018-01-12 19:53                                               ` Frederic Weisbecker
2018-01-12 14:58                                     ` Frederic Weisbecker
2018-01-12 15:15                                       ` Mike Galbraith
2018-01-12 17:00                                         ` Frederic Weisbecker
2018-01-12 18:08                                           ` Mike Galbraith
2018-01-12 17:24                                     ` Linus Torvalds
2018-01-09 13:36 ` [RFC 2/2] softirq: Introduce mask for __do_softirq() Dmitry Safonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515620880.3350.44.camel@arista.com \
    --to=dima@arista.com \
    --cc=0x7f454c46@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.levin@verizon.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=hannes@stressinduktion.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pabeni@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=rrendec@arista.com \
    --cc=sgruszka@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.