From: Dario Faggioli <dfaggioli@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Meng Xu <mengxu@cis.upenn.edu>
Subject: Re: [PATCH] xen/sched_rt: Move repl_timer into struct rt_private
Date: Thu, 11 Jan 2018 19:18:52 +0100 [thread overview]
Message-ID: <1515694732.30117.72.camel@suse.com> (raw)
In-Reply-To: <1515690052-4221-1-git-send-email-andrew.cooper3@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1444 bytes --]
On Thu, 2018-01-11 at 17:00 +0000, Andrew Cooper wrote:
> struct timer is only 48 bytes and repl_timer has a 1-to-1
> correspondance with
> struct rt_private, so having it referenced by pointer is wasteful.
>
> This avoids one memory allocation in rt_init(), and the resulting
> diffstat is:
>
> add/remove: 0/0 grow/shrink: 0/7 up/down: 0/-156 (-156)
> function old new delta
> rt_switch_sched 134 133 -1
> rt_context_saved 278 271 -7
> rt_vcpu_remove 253 245 -8
> rt_vcpu_sleep 234 218 -16
> repl_timer_handler 761 744 -17
> rt_deinit 44 20 -24
> rt_init 219 136 -83
>
> As an extra bit of cleanup noticed while making this change, there is
> no need
> to call cpumask_clear() on an zeroed memory allocation.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
Acked-by: Dario Faggioli <dfaggioli@suse.com>
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-01-11 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 17:00 [PATCH] xen/sched_rt: Move repl_timer into struct rt_private Andrew Cooper
2018-01-11 18:18 ` Dario Faggioli [this message]
2018-01-11 18:19 ` Dario Faggioli
2018-01-12 2:32 ` Meng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515694732.30117.72.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=mengxu@cis.upenn.edu \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.