[v2] usb: uhci: Add clk support to uhci-platform

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Fri, 2018-01-12 at 10:52 -0500, Alan Stern wrote:
> 
> As Sergei mentioned, please be consistent in the use of tabs vs. 
> spaces.
> 
> Do you have to worry about EPROBE_DEFER errors at any point?

I don't think so, not on the SoC I'm using but it might be worthwhile
adding support for it just in case...
> 
> > +     if (uhci->clk) {
> > +             ret = clk_prepare_enable(uhci->clk);
> > +             if (ret) {
> > +                     dev_err(&pdev->dev, "Error couldn't enable clock (%d)\n", ret);
> > +                     goto err_rmr;
> > +             }
> > +        }
> > +
> >        ret = usb_add_hcd(hcd, pdev->resource[1].start, IRQF_SHARED);
> >        if (ret)
> >                goto err_rmr;
> 
> This error path needs to call clk_disable_unprepare.

Yeah ok.

> > @@ -135,7 +150,10 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
> >   static int uhci_hcd_platform_remove(struct platform_device *pdev)
> >   {
> >        struct usb_hcd *hcd = platform_get_drvdata(pdev);
> > +     struct uhci_hcd *uhci = hcd_to_uhci(hcd);
> >   
> > +     if (uhci->clk)
> > +             clk_disable_unprepare(uhci->clk);
> >        usb_remove_hcd(hcd);
> >        usb_put_hcd(hcd);
> 
> Alan Stern
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html