From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>,
Naveen Panwar <naveen.panwar27@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
linux-doc <linux-doc@vger.kernel.org>,
Dan Carpenter <error27@gmail.com>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] Staging: netlogic: platform_net: Fixed '(' at the EOL
Date: Sun, 14 Jan 2018 12:22:06 -0800 [thread overview]
Message-ID: <1515961326.3045.8.camel@perches.com> (raw)
In-Reply-To: <20180114201008.GM13338@ZenIV.linux.org.uk>
On Sun, 2018-01-14 at 20:10 +0000, Al Viro wrote:
> On Sun, Jan 14, 2018 at 11:47:11PM +0530, Naveen Panwar wrote:
> > Removed '(' from the end of line, coding style issue.
>
> The one and only reason for warnings is that they point to
> places more likely to be dodgy. There is no inherent value
> in having e.g. checkpatch.pl STFU, all wanking about uniformity
> of style nonwithstanding.
[ long and complete response removed, available at
https://patchwork.kernel.org/patch/10162725/ ]
It was very generous of you to spend so much time on that
informative and thorough reply Al.
My own response was _much_ more terse.
What I wonder is if that sort of guided response can be
setup as documentation for kernel-newbies / janitors so
that future new submitters can have better ideas as to
what code can and should be improved instead of getting
simple and sometimes ill-advised whitespace changes.
cheers, Joe
next prev parent reply other threads:[~2018-01-14 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 18:17 [PATCH] Staging: netlogic: platform_net: Fixed '(' at the EOL Naveen Panwar
2018-01-14 18:44 ` Joe Perches
2018-01-14 20:10 ` Al Viro
2018-01-14 20:22 ` Joe Perches [this message]
2018-01-15 6:01 ` Naveen Panwar
2018-01-16 14:03 ` Naveen Panwar
2018-01-16 14:29 ` Dan Carpenter
2018-01-16 15:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515961326.3045.8.camel@perches.com \
--to=joe@perches.com \
--cc=corbet@lwn.net \
--cc=devel@driverdev.osuosl.org \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.panwar27@gmail.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.