Re: [PATCH v3] nl80211: take RCU read lock when calling ieee80211_bss_get_ie()

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2018-01-15 at 08:12 +0100, Dominik Brodowski wrote:
> As ieee80211_bss_get_ie() derefences an RCU to return ssid_ie, both
> the call to this function and any operation on this variable need
> protection by the RCU read lock.
> 
> Fixes: 44905265bc15 ("nl80211: don't expose wdev->ssid for most interfaces")
> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
> ---
> 
> > but after, perhaps it's easier to just do
> > 
> > 		if (ssid_ie &&
> > 		    nla_put(...)
> > 			goto nla_put_failure_rcu_locked;
> > 
> > and avoid the extra label (but yeah, it's getting late)
> 
> OK, done that (and updated the commit message), and testet it.
> 

Applied, thanks!

johannes