From: Martin Wilck <mwilck@suse.com>
To: Wuchongyun <wu.chongyun@h3c.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>
Cc: Guozhonghua <guozhonghua@h3c.com>, Changwei Ge <ge.changwei@h3c.com>
Subject: Re: [PATCH v2] multipathd: release uxsocket and resource when cancel thread
Date: Mon, 15 Jan 2018 11:59:13 +0100 [thread overview]
Message-ID: <1516013953.5699.28.camel@suse.com> (raw)
In-Reply-To: <CEB9978CF3252343BE3C67AC9F0086A342957B64@H3CMLB14-EX.srv.huawei-3com.com>
On Mon, 2018-01-15 at 09:25 +0000, Wuchongyun wrote:
> Hi Martin,
> Thank you for your reply! Below is the new patch according to your
> comments, please help to review this patch, thanks.
Almost there :-)
+
> + pthread_mutex_lock(&client_lock);
> + list_for_each_entry_safe(client_loop, client_tmp, &clients,
> node) {
> + list_del_init(&client_loop->node);
> + close(client_loop->fd);
> + client_loop->fd = -1;
> + FREE(client_loop);
> + }
> + pthread_mutex_unlock(&client_lock);
>
For the sake of future code rework and avoiding code duplication, could
you please put the content in a function called __dead_client() (or
similar), place that function right before dead_client(), change
dead_client() to call it, and then call it from here as well?
Sorry, I should have suggested that in my first review already.
Martin
--
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2018-01-15 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 9:25 [PATCH v2] multipathd: release uxsocket and resource when cancel thread Wuchongyun
2018-01-15 10:59 ` Martin Wilck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516013953.5699.28.camel@suse.com \
--to=mwilck@suse.com \
--cc=dm-devel@redhat.com \
--cc=ge.changwei@h3c.com \
--cc=guozhonghua@h3c.com \
--cc=wu.chongyun@h3c.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.