From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Mon, 15 Jan 2018 13:36:10 +0100 Subject: [RFT net-next v4 2/5] net: stmmac: dwmac-meson8b: simplify generating the clock names In-Reply-To: References: <20180114214858.7217-1-martin.blumenstingl@googlemail.com> <20180114214858.7217-3-martin.blumenstingl@googlemail.com> <1516016807.2608.13.camel@baylibre.com> Message-ID: <1516019770.2608.18.camel@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Mon, 2018-01-15 at 13:02 +0100, Martin Blumenstingl wrote: > > Here you'd allocate memory for each string which will remain until the driver > > unload. It's not much, but still, it is wasted memory. > > good catch, thank you! > maybe I should drop this patch for now and clean up the clock > registration in another series - I can try to get rid of the > "unneeded" members in struct meson8b_dwmac in a new patch. what do you > think? I think it would be wise, yes. Cheers Jerome From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [RFT net-next v4 2/5] net: stmmac: dwmac-meson8b: simplify generating the clock names Date: Mon, 15 Jan 2018 13:36:10 +0100 Message-ID: <1516019770.2608.18.camel@baylibre.com> References: <20180114214858.7217-1-martin.blumenstingl@googlemail.com> <20180114214858.7217-3-martin.blumenstingl@googlemail.com> <1516016807.2608.13.camel@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, ingrassia@epigenesys.com, linus.luessing@c0d3.blue, khilman@baylibre.com, linux-amlogic@lists.infradead.org, Neil Armstrong , peppe.cavallaro@st.com, alexandre.torgue@st.com To: Martin Blumenstingl Return-path: Received: from mail-wr0-f169.google.com ([209.85.128.169]:39261 "EHLO mail-wr0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932393AbeAOMgN (ORCPT ); Mon, 15 Jan 2018 07:36:13 -0500 Received: by mail-wr0-f169.google.com with SMTP id z48so11495262wrz.6 for ; Mon, 15 Jan 2018 04:36:12 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2018-01-15 at 13:02 +0100, Martin Blumenstingl wrote: > > Here you'd allocate memory for each string which will remain until the driver > > unload. It's not much, but still, it is wasted memory. > > good catch, thank you! > maybe I should drop this patch for now and clean up the clock > registration in another series - I can try to get rid of the > "unneeded" members in struct meson8b_dwmac in a new patch. what do you > think? I think it would be wise, yes. Cheers Jerome