All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Tomi Sarvela <tomi.p.sarvela@intel.com>,
	Zhenyu Wang <zhenyuw@linux.intel.com>,
	Sagar Arun Kamble <sagar.a.kamble@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
Date: Tue, 16 Jan 2018 11:53:47 +0200	[thread overview]
Message-ID: <1516096427.6376.4.camel@linux.intel.com> (raw)
In-Reply-To: <9ca9fd63-5e9b-d181-f60e-648ba071560c@intel.com>

On Mon, 2018-01-15 at 13:10 +0200, Tomi Sarvela wrote:
> On 15/01/18 12:28, Zhenyu Wang wrote:
> > On 2018.01.15 12:07:28 +0200, Joonas Lahtinen wrote:
> > > On Fri, 2018-01-12 at 14:08 +0800, Du, Changbin wrote:
> > > > On Fri, Jan 12, 2018 at 11:32:30AM +0530, Sagar Arun Kamble wrote:
> > > > > Is skl-gvtdvm not having vGPU active?
> > > > > 
> > > > > It has flag X86_FEATURE_HYPERVISOR set however it might be set on host too
> > > > > so relying intel_vgpu_active().
> > > > > 
> > > > 
> > > > Do you mean flag X86_FEATURE_HYPERVISOR is set on host, too? This is weird since this
> > > > flag indicates the OS is running on a hypervisor.
> > > 
> > > + CI folks and Zhenyu
> > > 
> > > Somehow, magically, the virtual machine seems to starts skipping all
> > > tests when GuC is disabled?
> > > 
> > > Has somebody actually validated that the tests results are valid for
> > > the virtual machine? Or is this a one-off CI quirk?
> > 
> > Are these tests really run in VM with GVT-g enabled on host?
> 
> These tests are ran on VM running on GVT-d (as name implies), not GVT-g.

I don't still understand how explicitly disabling GuC could make all
the tests skip on a machine that didn't use GuC to begin with. There
must be something wrong in the initialization code.

That intel_vgpu_active() check by my logic should not trigger in GVT-d
(because we don't have virtual GPU, we have the real deal, just without
stolen etc.), so I'm bit baffled.

Regards, Joonas

> 
> Tomi
> 
> > > PS. I'd do the check as early return condition at the top, like vGPU
> > > feature disabling elsewhere. It's not much point calculating the
> > > details (calling into functions like intel_uc_fw_is_selected) and then
> > > throwing results out afterwards :)
> > > 
> > 
> > yeah, better, and we do plan to support vGuC from ICL for vGPU.
> > 
> > > > 
> > > > > 
> > > > > On 1/11/2018 10:27 PM, Patchwork wrote:
> > > > > > == Series Details ==
> > > > > > 
> > > > > > Series: series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
> > > > > > URL   : https://patchwork.freedesktop.org/series/36343/
> > > > > > State : failure
> > > > > > 
> > > > > > == Summary ==
> > > > > > 
> > > > > > Series 36343v1 series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
> > > > > > https://patchwork.freedesktop.org/api/1.0/series/36343/revisions/1/mbox/
> > > > > > 
> > > > > > Test core_auth:
> > > > > >           Subgroup basic-auth:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test core_prop_blob:
> > > > > >           Subgroup basic:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test debugfs_test:
> > > > > >           Subgroup read_all_entries:
> > > > > >                   dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test drv_getparams_basic:
> > > > > >           Subgroup basic-eu-total:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-subslice-total:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test drv_hangman:
> > > > > >           Subgroup error-state-basic:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test gem_basic:
> > > > > >           Subgroup bad-close:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup create-close:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup create-fd-close:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test gem_busy:
> > > > > >           Subgroup basic-busy-default:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-hang-default:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm) fdo#104108 +2
> > > > > > Test gem_close_race:
> > > > > >           Subgroup basic-process:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-threads:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test gem_cpu_reloc:
> > > > > >           Subgroup basic:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test gem_cs_tlb:
> > > > > >           Subgroup basic-default:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test gem_ctx_create:
> > > > > >           Subgroup basic:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-files:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test gem_ctx_exec:
> > > > > >           Subgroup basic:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test gem_ctx_param:
> > > > > >           Subgroup basic:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-default:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test gem_ctx_switch:
> > > > > >           Subgroup basic-default:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-default-heavy:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > > Test gem_exec_basic:
> > > > > >           Subgroup basic-blt:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-bsd:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-bsd1:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-bsd2:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-default:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-render:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup basic-vebox:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup gtt-blt:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup gtt-bsd:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup gtt-bsd1:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup gtt-bsd2:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup gtt-default:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup gtt-render:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup gtt-vebox:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup readonly-blt:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup readonly-bsd:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup readonly-bsd1:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup readonly-bsd2:
> > > > > >                   pass       -> SKIP       (fi-skl-gvtdvm)
> > > > > >           Subgroup readonly-default:
> > > > > > WARNING: Long output truncated
> > > > > > 
> > > > > > da4321c7c088d01ad62b18d37dcfe5ef8d0b855d drm-tip: 2018y-01m-11d-14h-59m-37s UTC integration manifest
> > > > > > a0e8e84432b0 HAX: drm/i915/uc: Enable GuC/HuC for CI
> > > > > > 973357da236a drm/i915/guc: Don't enable GuC when vGPU is active
> > > > > > 
> > > > > > == Logs ==
> > > > > > 
> > > > > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7651/issues.html
> > > > 
> > > > 
> > > 
> > > -- 
> > > Joonas Lahtinen
> > > Open Source Technology Center
> > > Intel Corporation
> 
> 
> Tomi
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-01-16  9:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11 16:31 [PATCH 1/2] drm/i915/guc: Don't enable GuC when vGPU is active Sagar Arun Kamble
2018-01-11 16:31 ` [PATCH 2/2] HAX: drm/i915/uc: Enable GuC/HuC for CI Sagar Arun Kamble
2018-01-11 16:57 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active Patchwork
2018-01-12  6:02   ` Sagar Arun Kamble
2018-01-12  6:08     ` Du, Changbin
2018-01-15 10:07       ` Joonas Lahtinen
2018-01-15 10:28         ` Zhenyu Wang
2018-01-15 11:10           ` Tomi Sarvela
2018-01-16  9:53             ` Joonas Lahtinen [this message]
2018-01-16 10:17               ` Michal Wajdeczko
2018-01-17  2:36                 ` Du, Changbin
2018-01-17 11:18                   ` Tvrtko Ursulin
2018-01-18  9:42                 ` Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516096427.6376.4.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sagar.a.kamble@intel.com \
    --cc=tomi.p.sarvela@intel.com \
    --cc=zhenyuw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.