From: Martin Wilck <mwilck@suse.com>
To: Wuchongyun <wu.chongyun@h3c.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>
Cc: Guozhonghua <guozhonghua@h3c.com>,
Changwei Ge <ge.changwei@h3c.com>,
Changlimin <changlimin@h3c.com>
Subject: Re: [PATCH V4] multipathd: release uxsocket and resource when cancel thread
Date: Wed, 17 Jan 2018 08:39:27 +0100 [thread overview]
Message-ID: <1516174767.3303.4.camel@suse.com> (raw)
In-Reply-To: <CEB9978CF3252343BE3C67AC9F0086A342958024@H3CMLB14-EX.srv.huawei-3com.com>
Hi Wuchongyun,
another thing occured to me:
On Wed, 2018-01-17 at 02:33 +0000, Wuchongyun wrote:
>
> void uxsock_cleanup(void *arg)
> {
> + struct client *client_loop;
> + struct client *client_tmp;
> + int ux_sock = (int)arg;
> +
> + pthread_mutex_lock(&client_lock);
> + list_for_each_entry_safe(client_loop, client_tmp, &clients,
> node) {
> + _dead_client(client_loop);
> + }
> + pthread_mutex_unlock(&client_lock);
> +
> + close(ux_sock);
> +
Would it make sense to move the close(ux_sock) call further up
to avoid new clients trying to connect?
Martin
--
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2018-01-17 7:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 2:33 [PATCH V4] multipathd: release uxsocket and resource when cancel thread Wuchongyun
2018-01-17 7:39 ` Martin Wilck [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-17 8:15 Wuchongyun
2018-01-17 10:30 ` Martin Wilck
2018-01-17 19:05 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516174767.3303.4.camel@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=changlimin@h3c.com \
--cc=dm-devel@redhat.com \
--cc=ge.changwei@h3c.com \
--cc=guozhonghua@h3c.com \
--cc=wu.chongyun@h3c.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.