From: Johannes Berg <johannes@sipsolutions.net>
To: Pkshih <pkshih@realtek.com>,
"arend.vanspriel@broadcom.com" <arend.vanspriel@broadcom.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>
Cc: 莊彥宣 <yhchuang@realtek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH v2 05/10] rtlwifi: enable mac80211 fast-tx support
Date: Thu, 18 Jan 2018 11:09:45 +0100 [thread overview]
Message-ID: <1516270185.410.56.camel@sipsolutions.net> (raw)
In-Reply-To: <1516266330.3990.6.camel@realtek.com>
On Thu, 2018-01-18 at 09:05 +0000, Pkshih wrote:
>
> > /* fast-xmit doesn't handle fragmentation at all */
> > if (local->hw.wiphy->frag_threshold != (u32)-1 &&
> > !ieee80211_hw_check(&local->hw, SUPPORTS_TX_FRAG))
> > goto out;
> >
>
> Thank you for this point. This commit has not to set SUPPORTS_TX_FRAG,
> but only set SUPPORT_FAST_XMIT. I'll test and prepare for next
> submission.
But the point is that you *shouldn't* set SUPPORTS_TX_FRAG, and then
fast-xmit will only get used for non-fragmented setups, which
realistically is all anyone cares about anyway.
johannes
next prev parent reply other threads:[~2018-01-18 10:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 7:09 [PATCH v2 00/10] rtlwifi: fix some bugs and add btcoex functions pkshih
2018-01-11 7:09 ` [PATCH v2 01/10] rtlwifi: Use mutex to replace spin_lock to protect IPS and LPS pkshih
2018-01-12 19:36 ` Larry Finger
2018-01-11 7:09 ` [PATCH v2 02/10] rtlwifi: fix scan channel 1 fail after IPS pkshih
2018-01-15 18:49 ` Larry Finger
2018-01-11 7:09 ` [PATCH v2 03/10] rtlwifi: Add sta_statistics of mac80211's op, and set filled=0 by default pkshih
2018-01-15 18:51 ` Larry Finger
2018-01-16 15:42 ` Kalle Valo
2018-01-16 22:06 ` Johannes Berg
2018-01-11 7:09 ` [PATCH v2 04/10] rtlwifi: unlink bss when un-association pkshih
2018-01-15 18:53 ` Larry Finger
2018-01-11 7:09 ` [PATCH v2 05/10] rtlwifi: enable mac80211 fast-tx support pkshih
2018-01-15 18:54 ` Larry Finger
2018-01-16 15:45 ` Kalle Valo
2018-01-16 20:12 ` Arend van Spriel
2018-01-16 22:24 ` Johannes Berg
2018-01-17 8:37 ` Arend van Spriel
2018-01-17 8:43 ` Johannes Berg
2018-01-18 9:05 ` Pkshih
2018-01-18 10:09 ` Johannes Berg [this message]
2018-01-19 1:39 ` Pkshih
2018-01-11 7:09 ` [PATCH v2 06/10] rtlwifi: Support A-MSDU in A-MPDU capability pkshih
2018-01-15 18:55 ` Larry Finger
2018-01-11 7:09 ` [PATCH v2 07/10] rtlwifi: btcoex: Add power_on_setting routine pkshih
2018-01-15 19:19 ` Larry Finger
2018-01-16 1:28 ` Pkshih
2018-01-11 7:09 ` [PATCH v2 08/10] rtlwifi: btcoex: Remove global variables from btcoex pkshih
2018-01-15 19:02 ` Larry Finger
2018-01-11 7:09 ` [PATCH v2 09/10] rtlwifi: btcoex: Add common function for qeurying BT information pkshih
2018-01-15 19:15 ` Larry Finger
2018-01-16 0:55 ` Pkshih
2018-01-16 15:52 ` Kalle Valo
2018-01-16 17:02 ` Larry Finger
2018-01-11 7:09 ` [PATCH v2 10/10] rtlwifi: btcoex: add rfe_type parameter to btcoex pkshih
2018-01-15 19:17 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516270185.410.56.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=arend.vanspriel@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.