From: James Bottomley <jejb@linux.vnet.ibm.com>
To: weiping zhang <zhangweiping@didichuxing.com>, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] scsi: sd: add new match array for cache_type
Date: Thu, 18 Jan 2018 08:30:13 -0800 [thread overview]
Message-ID: <1516293013.3014.8.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180118141928.GA28320@bogon.didichuxing.com>
On Thu, 2018-01-18 at 22:19 +0800, weiping zhang wrote:
> - return sprintf(buf, "%s\n", sd_cache_types[ct]);
> + return sprintf(buf, "%s\n%s\nwrite:%s, read:%s\n",
> sd_cache_types[ct],
> + sd_wce_rcd[ct], sdkp->WCE ? "on" : "off",
> + sdkp->RCD ? "off" : "on");
I don't think we can do this. The output of the cache type in sysfs is
a user exported ABI. We'd potentially break it if we add extra stuff.
James
next prev parent reply other threads:[~2018-01-18 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 14:19 [PATCH v2] scsi: sd: add new match array for cache_type weiping zhang
2018-01-18 16:30 ` James Bottomley [this message]
2018-01-19 2:41 ` Martin K. Petersen
2018-01-19 4:46 ` weiping zhang
2018-01-23 0:23 ` Martin K. Petersen
2018-01-23 14:32 ` weiping zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516293013.3014.8.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=zhangweiping@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.