From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tom Herbert <tom@herbertland.com>
Cc: James Chapman <jchapman@katalix.com>,
Guillaume Nault <g.nault@alphalink.fr>,
David Miller <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] kcm: do not attach sockets if sk_user_data is already used
Date: Thu, 18 Jan 2018 11:46:33 -0800 [thread overview]
Message-ID: <1516304793.3606.26.camel@gmail.com> (raw)
In-Reply-To: <CALx6S34yLtP4QbOdOnNho4uFauk=dMDjQvDpeAHm0AakiyYeoA@mail.gmail.com>
On Thu, 2018-01-18 at 11:26 -0800, Tom Herbert wrote:
> On Thu, Jan 18, 2018 at 10:08 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > On Thu, 2018-01-18 at 09:46 -0800, Tom Herbert wrote:
> > >
> > > Then that's increasing the udp_sock structure size for a narrow use
> > > case which will get push back. I think it's going to be better to
> > > stick with one sock pointer. We could maybe redefine sk_user_data as a
> > > pointer to an allocated structure or array so it can hold multiple
> > > user_data pointers (in lieu of chaining).
> > >
> >
> > We do not have a lot of UDP sockets per host, I do not believe it
> > should be a problem adding stuff in them.
> >
>
> Eric,
>
> Is QUIC using unconnected sockets then?
Server side is using a bunch of unconnected sockets, usually one per
cpu.
Note that UDP stack has no 4-tuple proper support yet, and even if it
had, extra memory costs would be huge on servers handling millions of
flows.
next prev parent reply other threads:[~2018-01-18 19:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 11:32 [PATCH net-next] kcm: do not attach sockets if sk_user_data is already used James Chapman
2018-01-16 10:44 ` Guillaume Nault
2018-01-16 17:10 ` Eric Dumazet
2018-01-16 17:36 ` Tom Herbert
2018-01-16 19:00 ` David Miller
2018-01-17 11:13 ` James Chapman
2018-01-17 19:25 ` David Miller
2018-01-18 15:18 ` Guillaume Nault
2018-01-18 15:40 ` James Chapman
2018-01-18 16:29 ` Guillaume Nault
2018-01-18 17:30 ` James Chapman
2018-01-18 17:46 ` Tom Herbert
2018-01-18 18:08 ` Eric Dumazet
2018-01-18 19:26 ` Tom Herbert
2018-01-18 19:46 ` Eric Dumazet [this message]
2018-01-18 17:40 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516304793.3606.26.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=g.nault@alphalink.fr \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.