From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Alban Crequy <alban.crequy@gmail.com>, Alban Crequy <alban@kinvolk.io>
Cc: iago@kinvolk.io, dongsu@kinvolk.io, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
Seth Forshee <seth.forshee@canonical.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [RFC PATCH v2] ima,fuse: introduce new fs flag FS_NO_IMA_CACHE
Date: Thu, 18 Jan 2018 16:25:02 -0500 [thread overview]
Message-ID: <1516310702.3772.11.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180116151000.443-1-alban@kinvolk.io>
On Tue, 2018-01-16 at 16:10 +0100, Alban Crequy wrote:
> From: Alban Crequy <alban@kinvolk.io>
>
> This patch forces files to be re-measured, re-appraised and re-audited
> on file systems with the feature flag FS_NO_IMA_CACHE. In that way,
> cached integrity results won't be used.
>
> For now, this patch adds the new flag only FUSE filesystems. This is
> needed because the userspace FUSE process can change the underlying
> files at any time.
Thanks, it's working nicely.
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 511fbaabf624..2bd7e73ebc2a 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -2075,6 +2075,7 @@ struct file_system_type {
> #define FS_BINARY_MOUNTDATA 2
> #define FS_HAS_SUBTYPE 4
> #define FS_USERNS_MOUNT 8 /* Can be mounted by userns root */
> +#define FS_NO_IMA_CACHE 16 /* Force IMA to re-measure, re-appraise, re-audit files */
> #define FS_RENAME_DOES_D_MOVE 32768 /* FS will handle d_move() during rename() internally. */
> struct dentry *(*mount) (struct file_system_type *, int,
> const char *, void *);
>
Since IMA is going to need another flag, we probably should have a
consistent prefix (eg. "FS_IMA"). Maybe rename this flag to
FS_IMA_NO_CACHE. I'm also wondering if this change should be
separated from the IMA change.
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: zohar@linux.vnet.ibm.com (Mimi Zohar)
To: linux-security-module@vger.kernel.org
Subject: [RFC PATCH v2] ima,fuse: introduce new fs flag FS_NO_IMA_CACHE
Date: Thu, 18 Jan 2018 16:25:02 -0500 [thread overview]
Message-ID: <1516310702.3772.11.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180116151000.443-1-alban@kinvolk.io>
On Tue, 2018-01-16 at 16:10 +0100, Alban Crequy wrote:
> From: Alban Crequy <alban@kinvolk.io>
>
> This patch forces files to be re-measured, re-appraised and re-audited
> on file systems with the feature flag FS_NO_IMA_CACHE. In that way,
> cached integrity results won't be used.
>
> For now, this patch adds the new flag only FUSE filesystems. This is
> needed because the userspace FUSE process can change the underlying
> files at any time.
Thanks, it's working nicely.
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 511fbaabf624..2bd7e73ebc2a 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -2075,6 +2075,7 @@ struct file_system_type {
> #define FS_BINARY_MOUNTDATA 2
> #define FS_HAS_SUBTYPE 4
> #define FS_USERNS_MOUNT 8 /* Can be mounted by userns root */
> +#define FS_NO_IMA_CACHE 16 /* Force IMA to re-measure, re-appraise, re-audit files */
> #define FS_RENAME_DOES_D_MOVE 32768 /* FS will handle d_move() during rename() internally. */
> struct dentry *(*mount) (struct file_system_type *, int,
> const char *, void *);
>
Since IMA is going to need another flag, we probably should have a
consistent prefix (eg. "FS_IMA"). ?Maybe rename this flag to
FS_IMA_NO_CACHE. ?I'm also wondering if this change should be
separated from the IMA change.
Mimi
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Alban Crequy <alban.crequy@gmail.com>, Alban Crequy <alban@kinvolk.io>
Cc: iago@kinvolk.io, dongsu@kinvolk.io, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
Seth Forshee <seth.forshee@canonical.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [RFC PATCH v2] ima,fuse: introduce new fs flag FS_NO_IMA_CACHE
Date: Thu, 18 Jan 2018 16:25:02 -0500 [thread overview]
Message-ID: <1516310702.3772.11.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180116151000.443-1-alban@kinvolk.io>
On Tue, 2018-01-16 at 16:10 +0100, Alban Crequy wrote:
> From: Alban Crequy <alban@kinvolk.io>
>
> This patch forces files to be re-measured, re-appraised and re-audited
> on file systems with the feature flag FS_NO_IMA_CACHE. In that way,
> cached integrity results won't be used.
>
> For now, this patch adds the new flag only FUSE filesystems. This is
> needed because the userspace FUSE process can change the underlying
> files at any time.
Thanks, it's working nicely.
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 511fbaabf624..2bd7e73ebc2a 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -2075,6 +2075,7 @@ struct file_system_type {
> #define FS_BINARY_MOUNTDATA 2
> #define FS_HAS_SUBTYPE 4
> #define FS_USERNS_MOUNT 8 /* Can be mounted by userns root */
> +#define FS_NO_IMA_CACHE 16 /* Force IMA to re-measure, re-appraise, re-audit files */
> #define FS_RENAME_DOES_D_MOVE 32768 /* FS will handle d_move() during rename() internally. */
> struct dentry *(*mount) (struct file_system_type *, int,
> const char *, void *);
>
Since IMA is going to need another flag, we probably should have a
consistent prefix (eg. "FS_IMA"). Maybe rename this flag to
FS_IMA_NO_CACHE. I'm also wondering if this change should be
separated from the IMA change.
Mimi
next prev parent reply other threads:[~2018-01-18 21:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 15:10 [RFC PATCH v2] ima,fuse: introduce new fs flag FS_NO_IMA_CACHE Alban Crequy
2018-01-16 15:10 ` Alban Crequy
2018-01-18 21:25 ` Mimi Zohar [this message]
2018-01-18 21:25 ` Mimi Zohar
2018-01-18 21:25 ` Mimi Zohar
2018-01-19 10:35 ` Alban Crequy
2018-01-19 10:35 ` Alban Crequy
2018-01-19 16:56 ` Mimi Zohar
2018-01-19 16:56 ` Mimi Zohar
2018-01-19 16:56 ` Mimi Zohar
2018-01-22 9:16 ` Alban Crequy
2018-01-22 9:16 ` Alban Crequy
2018-01-22 12:56 ` Mimi Zohar
2018-01-22 12:56 ` Mimi Zohar
2018-01-22 12:56 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516310702.3772.11.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=alban.crequy@gmail.com \
--cc=alban@kinvolk.io \
--cc=dmitry.kasatkin@gmail.com \
--cc=dongsu@kinvolk.io \
--cc=hch@infradead.org \
--cc=iago@kinvolk.io \
--cc=james.l.morris@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=serge@hallyn.com \
--cc=seth.forshee@canonical.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.