All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Bolognani <abologna@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
	David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties
Date: Fri, 19 Jan 2018 15:34:42 +0100	[thread overview]
Message-ID: <1516372482.3278.29.camel@redhat.com> (raw)
In-Reply-To: <6a3fac69-c1e5-36cf-4781-5bb82b890efa@ozlabs.ru>

On Fri, 2018-01-19 at 17:15 +1100, Alexey Kardashevskiy wrote:
> > I think the existing qom-list interface does this already.
> 
> Nope, it does not. It takes path, not a type, so running with "-machine
> none" won't help.
> 
> > This won't solve the libvirt problem we were discussing, because it
> > needs an existing instance of the object.  libvirt wants to know the
> > machine properties *without* instantiating an instance.
> 
> My patch works with types, it creates an instance for a short time itself,
> this is why it does not do a thing for "pseries" as it is not a type and
> prints properties for the "pseries-2.12-machine" type.

Yeah, I took this for a spin and can confirm that it's pretty much
exactly what I was thinking about. The fact that the QMP command
instantiates objects behind the scenes is not an issue, at least
from libvirt's point of view: device-list-properties does the same
thing and we already use it quite happily; what matters is that we
can call this, along with all the other capabilities-collecting
QMP commands, in one go and on a single QEMU instance.

-- 
Andrea Bolognani / Red Hat / Virtualization

  parent reply	other threads:[~2018-01-19 14:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19  5:09 [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties Alexey Kardashevskiy
2018-01-19  5:19 ` David Gibson
2018-01-19  6:15   ` Alexey Kardashevskiy
2018-01-19  6:22     ` Alexey Kardashevskiy
2018-01-19 14:34     ` Andrea Bolognani [this message]
2018-01-23 10:08       ` Andrea Bolognani
2018-01-23 11:20         ` David Gibson
2018-01-23 12:03           ` Andrea Bolognani
2018-01-23 12:49             ` David Gibson
2018-01-23 13:33               ` Andrea Bolognani
2018-01-31  9:03               ` Alexey Kardashevskiy
2018-01-31 17:22                 ` Markus Armbruster
2018-01-31 17:22 ` Markus Armbruster
2018-02-02  2:02   ` Alexey Kardashevskiy
2018-02-02  7:37     ` Markus Armbruster
2018-02-05  3:30       ` Alexey Kardashevskiy
2018-02-07 12:18         ` Andrea Bolognani
2018-02-21  3:36 ` Alexey Kardashevskiy
2018-02-21 10:01   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516372482.3278.29.camel@redhat.com \
    --to=abologna@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.