From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: dts-bindings: usb-uhci: Document newly added properties From: Benjamin Herrenschmidt Message-Id: <1516408703.7489.13.camel@kernel.crashing.org> Date: Sat, 20 Jan 2018 11:38:23 +1100 To: Rob Herring Cc: devicetree , Joel Stanley , linux-usb@vger.kernel.org List-ID: T24gRnJpLCAyMDE4LTAxLTE5IGF0IDE3OjIyIC0wNjAwLCBSb2IgSGVycmluZyB3cm90ZToKPiBP biBUdWUsIEphbiAxNiwgMjAxOCBhdCAxMTowNjoxNUFNICsxMTAwLCBCZW5qYW1pbiBIZXJyZW5z Y2htaWR0IHdyb3RlOgo+ID4gQ29tbWl0IDQ2NDJkMzRhNDM5ZjgwZTE2YWYwZDU2ZWQ2MjU4YTMz YWJhZTI1N2EKPiA+ICJ1c2IvdWhjaTogQWRkIHN1cHBvcnQgZm9yIEFzcGVlZCBCTUMgU29DcyIg YWRkZWQKPiA+IHN1cHBvcnQgZm9yIGEgbmV3ICNwb3J0cyBwcm9wZXJ0eSwgYWxvbmcgd2l0aAo+ ID4gQXNwZWVkIHNwZWNpZmljIGNvbXBhdGlibGUgc3RyaW5ncy4gVGhpcyBhZGRzCj4gPiBkb2N1 bWVudGF0aW9uIGZvciB0aGVtLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBCZW5qYW1pbiBIZXJy ZW5zY2htaWR0IDxiZW5oQGtlcm5lbC5jcmFzaGluZy5vcmc+Cj4gPiAtLS0KPiA+ICBEb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3VzYi11aGNpLnR4dCB8IDYgKysrKysrCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi91c2ItdWhjaS50eHQgYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3VzYi11aGNpLnR4dAo+ID4gaW5kZXgg Mjk4MTMzNDE2Yzk3Li5jMTE1M2ViMzhhOWEgMTAwNjQ0Cj4gPiAtLS0gYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3VzYi11aGNpLnR4dAo+ID4gKysrIGIvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi91c2ItdWhjaS50eHQKPiA+IEBAIC0zLDggKzMs MTQgQEAgR2VuZXJpYyBQbGF0Zm9ybSBVSENJIENvbnRyb2xsZXIKPiA+ICAKPiA+ICBSZXF1aXJl ZCBwcm9wZXJ0aWVzOgo+ID4gIC0gY29tcGF0aWJsZSA6ICJnZW5lcmljLXVoY2kiIChkZXByZWNh dGVkOiAicGxhdGZvcm0tdWhjaSIpCj4gPiArICBzdXBwb3J0cyBhZGRpdGlvbmFsIEFzcGVlZCBz cGVjaWZpYyB3b3JrYXJvdW5kcyBieSBhbHNvCj4gPiArICBpbmNsdWRpbmcgdGhlICJhc3BlZWQs YXN0MjQwMC11aGNpIiBvciAiYXNwZWVkLGFzdDI1MDAtdWhjaSIKPiA+ICsgIHN0cmluZy4KPiAK PiBUaGF0J3MgdXN1YWxseSB3aHkgd2UgaGF2ZSBTb0MgY29tcGF0aWJsZXMsIHNvIHRoZSBkZXNj cmlwdGlvbiBkb2Vzbid0IAo+IHJlYWxseSBhZGQgYW55dGhpbmcuIENhbiB5b3UgZm9ybWF0IHdp dGggb25lIHZhbGlkIGNvbXBhdGlibGUgbGlzdCBwZXIgCj4gbGluZToKPiAKPiBjb21wYXRpYmxl IDogU2hvdWxkIGJlIG9uZSBvZjoKPiAJImFzcGVlZCxhc3QyNTAwLXVoY2kiLCAiZ2VuZXJpYy11 aGNpIgo+IAkiYXNwZWVkLGFzdDI0MDAtdWhjaSIsICJnZW5lcmljLXVoY2kiCj4gCSJnZW5lcmlj LXVoY2kiCj4gCSJwbGF0Zm9ybS11aGNpIiAoZGVwcmVjYXRlZCkKPiAKPiBXZSBzaG91bGQgZGVw cmVjYXRlICJnZW5lcmljLXVoY2kiIHRvbyBJTU8sIGJ1dCBoYXJkbHkgYW55b25lIGFkZHMgbmV3 IAo+IFVIQ0kgY29udHJvbGxlcnMuCgpTbyBJIG1hZGUgYSBtaXN0YWtlIGluIHRoZSBjb2RlLCBJ IG5lZWQgYm90aCB0aGUgYXNwZWVkIHNwZWNpZmljCmNvbXBhdGlibGUgKmFuZCogdGhlIHBsYXRm b3JtLXVoY2kgb25lIHNpbmNlIEkgZGlkbid0IGFtZW5kIHRoZSBkcml2ZXIKdG8gbWF0Y2ggb24g dGhlIGFzcGVlZCBvbmVzLiBJIHN1cHBvc2UgSSBjb3VsZCBqdXN0IHNlbmQgYSBmaXh1cCBwYXRj aAphcyBub2JvZHkgeWV0IGhhcyBkZXBsb3llZCBhbnl0aGluZyB5ZXQgb24gdGhlIGZpZWxkLgoK PiA+ICAtIHJlZyA6IFNob3VsZCBjb250YWluIDEgcmVnaXN0ZXIgcmFuZ2VzKGFkZHJlc3MgYW5k IGxlbmd0aCkKPiA+ICAtIGludGVycnVwdHMgOiBVSENJIGNvbnRyb2xsZXIgaW50ZXJydXB0Cj4g PiArLSAjcG9ydHM6IChvcHRpb25hbCkgMSBjZWxsLCBudW1iZXIgb2YgcG9ydHMgKG92ZXJyaWRl cwo+ID4gKyAgYXV0by1kZXRlY3Rpb24gd2hpY2ggaXMgbmVlZGVkIGFtb25nIG90aGVycyBvbiBz b21lIEFzcGVlZAo+ID4gKyAgcGFydHMpLgo+ID4gIAo+ID4gIEV4YW1wbGU6Cj4gPiAgCj4gPiAK PiA+IAo+ID4gLS0KPiA+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBs aW5lICJ1bnN1YnNjcmliZSBkZXZpY2V0cmVlIiBpbgo+ID4gdGhlIGJvZHkgb2YgYSBtZXNzYWdl IHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKPiA+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQg IGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAotLS0KVG8gdW5zdWJz Y3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVz YiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcK TW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8t aW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] dts-bindings: usb-uhci: Document newly added properties Date: Sat, 20 Jan 2018 11:38:23 +1100 Message-ID: <1516408703.7489.13.camel@kernel.crashing.org> References: <1516061175.31850.140.camel@kernel.crashing.org> <20180119232243.7lspbosyt4gvhote@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180119232243.7lspbosyt4gvhote@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: devicetree , Joel Stanley , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 2018-01-19 at 17:22 -0600, Rob Herring wrote: > On Tue, Jan 16, 2018 at 11:06:15AM +1100, Benjamin Herrenschmidt wrote: > > Commit 4642d34a439f80e16af0d56ed6258a33abae257a > > "usb/uhci: Add support for Aspeed BMC SoCs" added > > support for a new #ports property, along with > > Aspeed specific compatible strings. This adds > > documentation for them. > > > > Signed-off-by: Benjamin Herrenschmidt > > --- > > Documentation/devicetree/bindings/usb/usb-uhci.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/usb-uhci.txt b/Documentation/devicetree/bindings/usb/usb-uhci.txt > > index 298133416c97..c1153eb38a9a 100644 > > --- a/Documentation/devicetree/bindings/usb/usb-uhci.txt > > +++ b/Documentation/devicetree/bindings/usb/usb-uhci.txt > > @@ -3,8 +3,14 @@ Generic Platform UHCI Controller > > > > Required properties: > > - compatible : "generic-uhci" (deprecated: "platform-uhci") > > + supports additional Aspeed specific workarounds by also > > + including the "aspeed,ast2400-uhci" or "aspeed,ast2500-uhci" > > + string. > > That's usually why we have SoC compatibles, so the description doesn't > really add anything. Can you format with one valid compatible list per > line: > > compatible : Should be one of: > "aspeed,ast2500-uhci", "generic-uhci" > "aspeed,ast2400-uhci", "generic-uhci" > "generic-uhci" > "platform-uhci" (deprecated) > > We should deprecate "generic-uhci" too IMO, but hardly anyone adds new > UHCI controllers. So I made a mistake in the code, I need both the aspeed specific compatible *and* the platform-uhci one since I didn't amend the driver to match on the aspeed ones. I suppose I could just send a fixup patch as nobody yet has deployed anything yet on the field. > > - reg : Should contain 1 register ranges(address and length) > > - interrupts : UHCI controller interrupt > > +- #ports: (optional) 1 cell, number of ports (overrides > > + auto-detection which is needed among others on some Aspeed > > + parts). > > > > Example: > > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe devicetree" in > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html