From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Fri, 19 Jan 2018 17:53:59 -0800 Subject: [lustre-devel] [PATCH 1/2] staging: lustre: Fix comment style In-Reply-To: <1516290692-11642-2-git-send-email-fabian_huegel@web.de> References: <20180115150259.GA17991@kroah.com> <1516290692-11642-1-git-send-email-fabian_huegel@web.de> <1516290692-11642-2-git-send-email-fabian_huegel@web.de> Message-ID: <1516413239.14739.0.camel@perches.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Fabian Huegel , Oleg Drokin , Andreas Dilger , James Simmons , Lai Siyao , "John L . Hammond" , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Ben Evans , NeilBrown Cc: linux-kernel@i4.cs.fau.de, Christoph Volkert , linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org On Thu, 2018-01-18 at 16:51 +0100, Fabian Huegel wrote: > Most multi-line comments started on the first line, but the preferred > linux kernel style is to start multi-line comments on the second line. > Some comments became less readable after the change, so we changed them > to single-line comments. [] > diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h > > @@ -182,7 +179,8 @@ struct config_llog_data { > struct obd_export *cld_mgcexp; > struct mutex cld_lock; > int cld_type; > - unsigned int cld_stopping:1, /* we were told to stop > + unsigned int cld_stopping:1, /* > + * we were told to stop > * watching > */ > cld_lostlock:1; /* lock not requeued */ probably better for both of these to be bool instead of bitfield. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-747567-1516413254-2-15250457447351803115 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.136', Host='smtp3.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516413254; b=FJsExqCd2ibJ2cMp7ABHCkC+4Oyym8q/N9WndUKA8d0j7ER eenfmYtUigcsP0qDtP8OBX/VrBdXzQPDd0kcRoriNUdIJE+2cITg0TL3ravhSFEh 4O5Nl/ITNEvvULVcSAkP2m+6WENzmHwZyYPbKXyEXunYlKyRauyx/urpZso7RdtV BVKwLdslKIRSmfke5/pQevqCd83XJSTnHJI6wuUnnD/0khaFF9eLwivxmMHCN3U1 Y3ofs1DqfIjj0WSP2yvo4HcDrtKuFZ2JXcibhauNHriJxWrs4JIr+VuRtGgwZpQp 9L++0wXL7rr7AeDNrr50yab8sLYZrjgwRgHFDyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=message-id:subject:from:to:date :in-reply-to:references:mime-version:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1516413254; bh=L /OeWwjxj+MlMRHl3p43iWY3YK+Y+euhWftwIsPAX9o=; b=jjGOrj6cti8neCV78 2igEt9pC3DTKhYG6RMBjjlasGQyTcVP93eo+/dT8lqqD9cGvn6qny4tQdiWjww31 L6d1CBD03+ejwicj+4IjDdQDm1IUGoMS4C7e5e6Lb78SHWiswO+QakKImx3aLAfN 9fTVINCwt6zQz0iO5vFymjiSWmUgeG8R6wqjQNsprT35x/vww06dg5WZK6pCk3zp 6JYvMPjVOYvLgV4L1osEBux10aZY2GK111SX6Qg/WC2ADbodyF/Tibzl1CjWkNL4 f7I4eXpgmXsEMlUyMRg6JW7Lb/adkVlnScLu0IJSnWU5EOq5P8yUpb/G9TCTD66I CICzg== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=perches.com; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=perches.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=perches.com; iprev=pass policy.iprev=140.211.166.136 (smtp3.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=silver.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=silver.osuosl.org x-ptr-lookup=smtp3.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=perches.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org X-Session-Marker: 6A6F6540706572636865732E636F6D X-Remote-Spam-Summary: 2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::::::::::::::::::::, RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3871:4321:5007:9038:10004:10400:10848:11026:11232:11657:11658:11914:12043:12048:12294:12296:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21627:30054:30070:30091, 0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SPF:, MSBL:0, DNSBL:none, Custom_rules:0:0:0, LFtime:1, LUA_SUMMARY:none X-HE-Tag: snow37_2301618f7085d X-Filterd-Recvd-Size: 2137 Message-ID: <1516413239.14739.0.camel@perches.com> Subject: Re: [PATCH 1/2] staging: lustre: Fix comment style From: Joe Perches To: Fabian Huegel , Oleg Drokin , Andreas Dilger , James Simmons , Lai Siyao , "John L . Hammond" , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Ben Evans , NeilBrown Date: Fri, 19 Jan 2018 17:53:59 -0800 In-Reply-To: <1516290692-11642-2-git-send-email-fabian_huegel@web.de> References: <20180115150259.GA17991@kroah.com> <1516290692-11642-1-git-send-email-fabian_huegel@web.de> <1516290692-11642-2-git-send-email-fabian_huegel@web.de> X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@i4.cs.fau.de, Christoph Volkert , linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, 2018-01-18 at 16:51 +0100, Fabian Huegel wrote: > Most multi-line comments started on the first line, but the preferred > linux kernel style is to start multi-line comments on the second line. > Some comments became less readable after the change, so we changed them > to single-line comments. [] > diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h > > @@ -182,7 +179,8 @@ struct config_llog_data { > struct obd_export *cld_mgcexp; > struct mutex cld_lock; > int cld_type; > - unsigned int cld_stopping:1, /* we were told to stop > + unsigned int cld_stopping:1, /* > + * we were told to stop > * watching > */ > cld_lostlock:1; /* lock not requeued */ probably better for both of these to be bool instead of bitfield. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel