All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marcel Holtmann <marcel@holtmann.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Ferry Toth gmail <fntoth@gmail.com>
Cc: "Gustavo F. Padovan" <gustavo@padovan.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Bluez mailing list <linux-bluetooth@vger.kernel.org>,
	linux-serial@vger.kernel.org,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH 1/2] Bluetooth: hci_bcm: Remove platform_device support
Date: Mon, 22 Jan 2018 14:15:21 +0200	[thread overview]
Message-ID: <1516623321.7000.1175.camel@linux.intel.com> (raw)
In-Reply-To: <83ACB297-D092-4512-AC5B-3AF1137BE194@holtmann.org>

On Mon, 2018-01-22 at 13:01 +0100, Marcel Holtmann wrote:

> > > > Anyways it looks like this will be really hard to do without
> > > > access
> > > > to the hardware.
> > > 
> > > I can do a BAT.
> > 
> > Right, sorry I was not clear, when I was talking about hardware
> > access I was not (not only) referring to testing.
> > 
> > The problem is that to figure out how to hook all this together
> > will require poking around on the hardware, looking in sysfs,
> > finding
> > some id we can use in a pci_serdev_register_devices() to add to
> > drivers/tty/serdev/core.c so that it only turns the serial port on
> > the Edison into a serdev and not somewhere else, etc.
> > 
> > But thinking about this more, I too have higher priority items on
> > my TODO list, so as much as I would like to see this cleaned up,
> > lets shelf this for now until you have time to look into this.
> > 
> > When you do find time, if you've any questions I'm happy to help.
> 
> so in theory the Edison board has SFI. Problem is just that I am not
> sure the SFI on the board is fully correct and contains enough
> information to identify the serial port correctly.

Unfortunately SFI was so badly designed that board (hard coded) data is
needed.

> If no one is willing to help port this over to serdev, then one option
> is just to rip it out and see who complains.

Me in the first place. + I guess at least couple of users as of my
knowledge. + Undefined amount of swindled users of Edison who is trying
or already did a switch to vanilla kernel.

>  Or include a version that is trying its best and see who reports
> issues and who helps to fix it. I am now regretting that I accepted
> the Edison support in the first place, but sadly serdev was not yet
> fully baked at that point.

+Cc: Ferry, who might be interested in the helping with it.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2018-01-22 12:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-21 21:46 [PATCH 1/2] Bluetooth: hci_bcm: Remove platform_device support Hans de Goede
2018-01-21 21:46 ` [PATCH 2/2] Bluetooth: hci_bcm: Close serdev on failure to set power on bcm_open() Hans de Goede
2018-01-22  2:20   ` Marcel Holtmann
2018-01-22  2:24 ` [PATCH 1/2] Bluetooth: hci_bcm: Remove platform_device support Marcel Holtmann
2018-01-22  8:23   ` Hans de Goede
2018-01-22  9:42     ` Andy Shevchenko
     [not found]       ` <1516614127.7000.1152.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-01-22 11:27         ` Hans de Goede
2018-01-22 11:27           ` Hans de Goede
2018-01-22 11:33           ` Andy Shevchenko
2018-01-22 11:49             ` Hans de Goede
     [not found]               ` <0cae9024-887a-45f7-7710-1684f9c0e54e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-01-22 12:01                 ` Marcel Holtmann
2018-01-22 12:01                   ` Marcel Holtmann
2018-01-22 12:15                   ` Andy Shevchenko [this message]
2018-01-23 23:49                     ` Ferry Toth
2018-01-22 19:57                 ` Marcel Holtmann
2018-01-22 19:57                   ` Marcel Holtmann
2018-01-22 20:56                   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516623321.7000.1175.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=fntoth@gmail.com \
    --cc=gustavo@padovan.org \
    --cc=hdegoede@redhat.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.