From: Johannes Berg <johannes@sipsolutions.net>
To: tamizhr@codeaurora.org
Cc: linux-wireless@vger.kernel.org, tamizhr@qti.qualcomm.com,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Subject: Re: [PATCH 2/4] cfg80211: enable setting cqm config for AP mode
Date: Mon, 22 Jan 2018 14:01:02 +0100 [thread overview]
Message-ID: <1516626062.2508.26.camel@sipsolutions.net> (raw)
In-Reply-To: <1516174276-16789-3-git-send-email-tamizhr@codeaurora.org>
In addition to what I said before, you should also document which CQM
modes are actually available per station.
Perhaps the feature bit also needs to be per mode, since in mac80211 at
least you're only implementing signal monitoring, not
nl80211_set_cqm_txe()?
johannes
next prev parent reply other threads:[~2018-01-22 13:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 7:31 [PATCH 0/4] cfg80211/mac80211: cqm rssi config for AP mode tamizhr
2018-01-17 7:31 ` [PATCH 1/4] wireless: allow send peer mac in rssi cqm notify tamizhr
2018-01-22 12:56 ` Johannes Berg
2018-01-17 7:31 ` [PATCH 2/4] cfg80211: enable setting cqm config for AP mode tamizhr
2018-01-22 12:56 ` Johannes Berg
2018-01-22 13:01 ` Johannes Berg [this message]
2018-01-17 7:31 ` [PATCH 3/4] mac80211: " tamizhr
2018-01-22 12:57 ` Johannes Berg
2018-01-17 7:31 ` [PATCH 4/4] mac80211: implement cqm using rx data signal tamizhr
2018-01-22 13:01 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516626062.2508.26.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
--cc=tamizhr@codeaurora.org \
--cc=tamizhr@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.