From: Ley Foon Tan <ley.foon.tan@intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Ley Foon Tan <lftan@altera.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: rfi@lists.rocketboards.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: Re: [PATCH] PCI: altera: Fix bool initialization in tlp_read_packet
Date: Mon, 22 Jan 2018 23:28:08 +0800 [thread overview]
Message-ID: <1516634888.2377.21.camel@intel.com> (raw)
In-Reply-To: <20180120032651.GA14512@embeddedgus>
On Fri, 2018-01-19 at 21:26 -0600, Gustavo A. R. Silva wrote:
> Bool initializations should use true and false.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: eaa6111b70a7 ("PCI: altera: Add Altera PCIe host controller
> driver")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/pci/host/pcie-altera.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-
> altera.c
> index 5cc4f59..f9ee090 100644
> --- a/drivers/pci/host/pcie-altera.c
> +++ b/drivers/pci/host/pcie-altera.c
> @@ -156,7 +156,7 @@ static bool altera_pcie_valid_device(struct
> altera_pcie *pcie,
> static int tlp_read_packet(struct altera_pcie *pcie, u32 *value)
> {
> int i;
> - bool sop = 0;
> + bool sop = false;
> u32 ctrl;
> u32 reg0, reg1;
> u32 comp_status = 1;
> --
> 2.7.4
Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>
next prev parent reply other threads:[~2018-01-22 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 3:26 [PATCH] PCI: altera: Fix bool initialization in tlp_read_packet Gustavo A. R. Silva
2018-01-22 15:28 ` Ley Foon Tan [this message]
2018-02-28 17:00 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516634888.2377.21.camel@intel.com \
--to=ley.foon.tan@intel.com \
--cc=bhelgaas@google.com \
--cc=garsilva@embeddedor.com \
--cc=gustavo@embeddedor.com \
--cc=lftan@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rfi@lists.rocketboards.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.