From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serhey Popovych Subject: [PATCH iproute2-next 0/2] ip/tunnel: Unify collect metadata handling Date: Mon, 22 Jan 2018 18:46:52 +0200 Message-ID: <1516639614-12960-1-git-send-email-serhe.popovych@gmail.com> Cc: jbenc@redhat.com, u9012063@gmail.com, julien@cumulusnetworks.com To: netdev@vger.kernel.org Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:47103 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbeAVQry (ORCPT ); Mon, 22 Jan 2018 11:47:54 -0500 Received: by mail-wm0-f67.google.com with SMTP id 143so17538716wma.5 for ; Mon, 22 Jan 2018 08:47:53 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: With this series I want to unify collect metadata handling in tunnels: 1) Use "collect_metadata" name for JSON and "external" keyword for non-JSON printing. Do not *print* any options when tunnel in collect metadata mode: gre6 already do this, so just apply to others. 2) Do not *add* any attributes when configuring gre tunnel in collect metadata mode. Other tunnels (e.g. gre6, iptnl, ip6tnl) alredy do that. This is next step in ipv4 and ipv6 modules unification to prepare for merge in the future. Any comments, suggestions and criticism as always welcome. Thanks, Serhii Serhey Popovych (2): ip/tunnel: Be consistent when printing tunnel collect metadata gre/gre6: Unify attribute addition to netlink buffer ip/link_gre.c | 50 ++++++++++++++++++++++++-------------------------- ip/link_gre6.c | 13 ++++++++----- ip/link_ip6tnl.c | 6 ++++-- ip/link_iptnl.c | 6 ++++-- 4 files changed, 40 insertions(+), 35 deletions(-) -- 1.7.10.4