Re: [PATCH] dma-buf: fix reservation_object_wait_timeout_rcu once more

[Lyude Paul <lyude@redhat.com>]

Could you please make sure to add Cc: stable@vger.kernel.org for this? This is
causing crashing of wayland sessions on Fedora so we should definitely get
this into stable.

Other then that:

Tested-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>

On Mon, 2018-01-22 at 20:32 +0100, Christian König wrote:
> We need to set shared_count even if we already have a fence to wait for.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>  drivers/dma-buf/reservation.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c
> index 461afa9febd4..649c0cebf5b1 100644
> --- a/drivers/dma-buf/reservation.c
> +++ b/drivers/dma-buf/reservation.c
> @@ -506,14 +506,14 @@ long reservation_object_wait_timeout_rcu(struct
> reservation_object *obj,
>  		fence = NULL;
>  	}
>  
> -	if (!fence && wait_all) {
> +	if (wait_all) {
>  		struct reservation_object_list *fobj =
>  						rcu_dereference(obj-
> >fence);
>  
>  		if (fobj)
>  			shared_count = fobj->shared_count;
>  
> -		for (i = 0; i < shared_count; ++i) {
> +		for (i = 0; !fence && i < shared_count; ++i) {
>  			struct dma_fence *lfence = rcu_dereference(fobj-
> >shared[i]);
>  
>  			if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
-- 
Cheers,
	Lyude Paul
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel