diff for duplicates of <1516653723.2545.37.camel@wdc.com> diff --git a/a/1.txt b/N1/1.txt index f90feb2..c3ab1f2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,18 @@ -T24gTW9uLCAyMDE4LTAxLTIyIGF0IDEyOjIzIC0wODAwLCBKb2UgUGVyY2hlcyB3cm90ZToNCj4g -T24gTW9uLCAyMDE4LTAxLTIyIGF0IDA4OjUzICswMTAwLCBKb2hhbm5lcyBUaHVtc2hpcm4gd3Jv -dGU6DQo+ID4gVXNlIHByX2RlYnVnIGluc3RlYWQgb2YgaGFuZCBjcmFmdGVkIG1hY3Jvcy4gVGhp -cyB3YXkgaXQgaXMgbm90IG5lZWRlZCB0bw0KPiA+IHJlLWNvbXBpbGUgdGhlIGtlcm5lbCB0byBl -bmFibGUgYnNnIGRlYnVnIG91dHB1dHMgYW5kIGl0J3MgcG9zc2libGUgdG8NCj4gPiBzZWxlY3Rp -dmVseSBlbmFibGUgc3BlY2lmaWMgcHJpbnRzLg0KPiANCj4gUGVyaGFwcyBiZXR0ZXIgdG8gdXNl -DQo+IA0KPiAjZGVmaW5lIGJzZ19kYmcoYmQsIGZtdCwgLi4uKSBcDQo+IAlwcl9kZWJ1ZyhiZC0+ -bmFtZSwgZm10LCAjI19fVkFfQVJHU19fKQ0KDQpIZWxsbyBKb2UsDQoNCldoeSBkbyB5b3UgdGhp -bmsgdGhhdCB3b3VsZCBiZSBiZXR0ZXI/DQoNClRoYW5rcywNCg0KQmFydC4= +On Mon, 2018-01-22 at 12:23 -0800, Joe Perches wrote: +> On Mon, 2018-01-22 at 08:53 +0100, Johannes Thumshirn wrote: +> > Use pr_debug instead of hand crafted macros. This way it is not needed to +> > re-compile the kernel to enable bsg debug outputs and it's possible to +> > selectively enable specific prints. +> +> Perhaps better to use +> +> #define bsg_dbg(bd, fmt, ...) \ +> pr_debug(bd->name, fmt, ##__VA_ARGS__) + +Hello Joe, + +Why do you think that would be better? + +Thanks, + +Bart. diff --git a/a/content_digest b/N1/content_digest index 7d9b78c..031a7c3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -10,14 +10,23 @@ " linux-block@vger.kernel.org <linux-block@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gTW9uLCAyMDE4LTAxLTIyIGF0IDEyOjIzIC0wODAwLCBKb2UgUGVyY2hlcyB3cm90ZToNCj4g\n" - "T24gTW9uLCAyMDE4LTAxLTIyIGF0IDA4OjUzICswMTAwLCBKb2hhbm5lcyBUaHVtc2hpcm4gd3Jv\n" - "dGU6DQo+ID4gVXNlIHByX2RlYnVnIGluc3RlYWQgb2YgaGFuZCBjcmFmdGVkIG1hY3Jvcy4gVGhp\n" - "cyB3YXkgaXQgaXMgbm90IG5lZWRlZCB0bw0KPiA+IHJlLWNvbXBpbGUgdGhlIGtlcm5lbCB0byBl\n" - "bmFibGUgYnNnIGRlYnVnIG91dHB1dHMgYW5kIGl0J3MgcG9zc2libGUgdG8NCj4gPiBzZWxlY3Rp\n" - "dmVseSBlbmFibGUgc3BlY2lmaWMgcHJpbnRzLg0KPiANCj4gUGVyaGFwcyBiZXR0ZXIgdG8gdXNl\n" - "DQo+IA0KPiAjZGVmaW5lIGJzZ19kYmcoYmQsIGZtdCwgLi4uKSBcDQo+IAlwcl9kZWJ1ZyhiZC0+\n" - "bmFtZSwgZm10LCAjI19fVkFfQVJHU19fKQ0KDQpIZWxsbyBKb2UsDQoNCldoeSBkbyB5b3UgdGhp\n" - bmsgdGhhdCB3b3VsZCBiZSBiZXR0ZXI/DQoNClRoYW5rcywNCg0KQmFydC4= + "On Mon, 2018-01-22 at 12:23 -0800, Joe Perches wrote:\n" + "> On Mon, 2018-01-22 at 08:53 +0100, Johannes Thumshirn wrote:\n" + "> > Use pr_debug instead of hand crafted macros. This way it is not needed to\n" + "> > re-compile the kernel to enable bsg debug outputs and it's possible to\n" + "> > selectively enable specific prints.\n" + "> \n" + "> Perhaps better to use\n" + "> \n" + "> #define bsg_dbg(bd, fmt, ...) \\\n" + "> \tpr_debug(bd->name, fmt, ##__VA_ARGS__)\n" + "\n" + "Hello Joe,\n" + "\n" + "Why do you think that would be better?\n" + "\n" + "Thanks,\n" + "\n" + Bart. -7e06897071209a338c7b7f0da8f51c3b5998153da8c68c3db2dbfbef110aa8b1 +16d0a612342a91c33eda1a884b5d0345a3897b55c6b86af12418be4c4d27744c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.