From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: hpa@zytor.com, "Mehta, Sohil" <sohil.mehta@intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "mitake@dcl.info.waseda.ac.jp" <mitake@dcl.info.waseda.ac.jp>
Subject: Re: [PATCH v1] x86/io: Define readq()/writeq() to use 64-bit type
Date: Tue, 23 Jan 2018 10:32:04 +0200 [thread overview]
Message-ID: <1516696324.7000.1185.camel@linux.intel.com> (raw)
In-Reply-To: <FDFCAF1F-F4F8-4376-AD78-6208008F63DE@zytor.com>
On Mon, 2018-01-22 at 16:46 -0800, hpa@zytor.com wrote:
> On January 22, 2018 4:32:14 PM PST, "Mehta, Sohil" <sohil.mehta@intel.
> com> wrote:
> > On Fri, 2018-01-19 at 16:33 +0200, Andy Shevchenko wrote:
> > > +build_mmio_read(readq, "q", unsigned long long, "=r", :"memory")
> > > +build_mmio_read(__readq, "q", unsigned long long, "=r", )
> > > +build_mmio_write(writeq, "q", unsigned long long, "r", :"memory")
> > > +build_mmio_write(__writeq, "q", unsigned long long, "r", )
> > >
> > > #define readq_relaxed(a) __readq(a)
> > > #define writeq_relaxed(v, a) __writeq(v, a)
> >
> > The patch works for me:
> >
> > Tested-by: Sohil Mehta <sohil.mehta@intel.com>
> >
> Wouldn't simply u64 make more sense?
It would break a common style used in this module for the rest of
accessors.
So, I prefer to go with unsigned long long and change later, if needed,
from POD types to uNN ones in entire file.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-01-23 8:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 14:33 [PATCH v1] x86/io: Define readq()/writeq() to use 64-bit type Andy Shevchenko
2018-01-23 0:32 ` Mehta, Sohil
2018-01-23 0:46 ` hpa
2018-01-23 8:32 ` Andy Shevchenko [this message]
2018-01-29 15:45 ` Andy Shevchenko
2018-02-13 16:58 ` [tip:x86/urgent] " tip-bot for Andy Shevchenko
2018-03-27 15:10 ` Andy Shevchenko
2018-03-31 10:19 ` Ingo Molnar
2018-03-31 10:22 ` Ingo Molnar
2018-03-31 12:06 ` Andy Shevchenko
2018-03-31 12:15 ` Andy Shevchenko
2018-03-31 18:45 ` Ingo Molnar
2018-04-02 14:55 ` Andy Shevchenko
2018-04-24 16:51 ` Andy Shevchenko
2018-03-31 12:05 ` Andy Shevchenko
2018-03-31 10:20 ` [tip:x86/platform] " tip-bot for Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516696324.7000.1185.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mitake@dcl.info.waseda.ac.jp \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.