All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tal Gilboa <talgi@mellanox.com>, Eric Dumazet <edumazet@google.com>
Cc: David Miller <davem@davemloft.net>,
	"ncardwell@google.com" <ncardwell@google.com>,
	"ycheng@google.com" <ycheng@google.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Tariq Toukan <tariqt@mellanox.com>,
	Amir Ancel <amira@mellanox.com>
Subject: Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue
Date: Wed, 24 Jan 2018 07:09:04 -0800	[thread overview]
Message-ID: <1516806544.3715.18.camel@gmail.com> (raw)
In-Reply-To: <e2d2db0f-94d7-dc1e-f99c-b419d50fbdcc@mellanox.com>

On Wed, 2018-01-24 at 16:42 +0200, Tal Gilboa wrote:
> Hi Eric,
> My choice of words in my comment was misplaced, and I apologies. It 
> completely missed the point. I understand, of course, the importance of 
> optimizing real-life scenarios.
> 
> We are currently evaluating this patch and if/how it might affect our 
> customers. We would also evaluate your suggestion below.
> 
> We will contact you if and when we have a real concern.
> Thanks.

Sure, I am curious how a 50% regression can be possible as a matter of
fact, so please update even if this caused by some specific synthetic
test conditions.

Thanks.

  reply	other threads:[~2018-01-24 15:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06  5:21 [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue Eric Dumazet
2017-10-06  5:21 ` [PATCH net-next 1/7] net: add rb_to_skb() and other rb tree helpers Eric Dumazet
2017-10-06  5:21 ` [PATCH net-next 2/7] tcp: uninline tcp_write_queue_purge() Eric Dumazet
2017-10-06  5:21 ` [PATCH net-next 3/7] tcp: tcp_tx_timestamp() cleanup Eric Dumazet
2017-10-06  5:21 ` [PATCH net-next 4/7] tcp: tcp_mark_head_lost() optimization Eric Dumazet
2017-10-06  5:21 ` [PATCH net-next 5/7] tcp: reduce tcp_fastretrans_alert() verbosity Eric Dumazet
2017-10-06  5:21 ` [PATCH net-next 6/7] tcp: pass previous skb to tcp_shifted_skb() Eric Dumazet
2017-10-06  5:21 ` [PATCH net-next 7/7] tcp: implement rb-tree based retransmit queue Eric Dumazet
2017-10-06 23:31 ` [PATCH net-next 0/7] " David Miller
2018-01-21 20:52   ` Tal Gilboa
2018-01-21 23:47     ` Eric Dumazet
2018-01-24 14:42       ` Tal Gilboa
2018-01-24 15:09         ` Eric Dumazet [this message]
2018-02-06 13:51           ` Tal Gilboa
2018-02-06 14:19             ` Eric Dumazet
2018-02-06 15:22               ` David Laight
2018-02-06 15:52                 ` Eric Dumazet
2018-02-06 16:27                   ` Tal Gilboa
2018-02-06 17:05                     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516806544.3715.18.camel@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=amira@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=talgi@mellanox.com \
    --cc=tariqt@mellanox.com \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.