From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel Axtens <dja@axtens.net>, netdev@vger.kernel.org
Cc: Jason Wang <jasowang@redhat.com>, Pravin Shelar <pshelar@ovn.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Manish.Chopra@cavium.com, dev@openvswitch.org
Subject: Re: [PATCH v2 0/4] Check size of packets before sending
Date: Thu, 25 Jan 2018 06:35:04 -0800 [thread overview]
Message-ID: <1516890904.3715.50.camel@gmail.com> (raw)
In-Reply-To: <87607qdpdf.fsf@linkitivity.dja.id.au>
On Fri, 2018-01-26 at 00:44 +1100, Daniel Axtens wrote:
> Hi Eric,
>
> > May I ask which tree are you targeting ?
> >
> > ( Documentation/networking/netdev-FAQ.txt )
>
> I have been targeting net-next, but I haven't pulled for about two
> weeks. I will rebase and if there are conflicts I will resend early next
> week.
>
> > Anything touching GSO is very risky and should target net-next,
> > especially considering 4.15 is released this week end.
> >
> > Are we really willing to backport this intrusive series in stable
> > trees, or do we have a smaller fix for bnx2x ?
>
> I do actually have a smaller fix for bnx2x, although it would need more work:
> https://patchwork.ozlabs.org/patch/859410/
>
> It leaves open the possibility of too-large packets causing issues on
> other drivers. DaveM wasn't a fan: https://patchwork.ozlabs.org/patch/859410/#1839429
Yes, I know he prefers a generic solution, but I am pragmatic here.
Old kernels are very far from current GSO stack in net-next.
Backporting all the dependencies is going to be very boring/risky.
next prev parent reply other threads:[~2018-01-25 14:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 4:31 [PATCH v2 0/4] Check size of packets before sending Daniel Axtens
2018-01-25 4:31 ` [PATCH v2 1/4] net: rename skb_gso_validate_mtu -> skb_gso_validate_network_len Daniel Axtens
2018-01-25 4:31 ` [PATCH v2 2/4] net: move skb_gso_mac_seglen to skbuff.h Daniel Axtens
2018-01-25 4:31 ` [PATCH v2 3/4] net: is_skb_forwardable: check the size of GSO segments Daniel Axtens
2018-01-25 4:31 ` [PATCH v2 4/4] net: check the size of a packet in validate_xmit_skb Daniel Axtens
2018-01-25 12:40 ` [PATCH v2 0/4] Check size of packets before sending Eric Dumazet
[not found] ` <1516884036.3715.45.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-25 13:44 ` Daniel Axtens
2018-01-25 14:35 ` Eric Dumazet [this message]
2018-01-29 3:20 ` Daniel Axtens
2018-01-29 16:37 ` David Miller
[not found] ` <20180125043109.28332-1-dja-Yfaxwxk/+vWsTnJN9+BGXg@public.gmane.org>
2018-01-25 15:24 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516890904.3715.50.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=Manish.Chopra@cavium.com \
--cc=dev@openvswitch.org \
--cc=dja@axtens.net \
--cc=jasowang@redhat.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.