diff for duplicates of <1516900017.2726.1.camel@wdc.com> diff --git a/a/1.txt b/N1/1.txt index 5904301..a870483 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,11 +1,16 @@ -T24gU2F0LCAyMDE4LTAxLTEzIGF0IDIzOjU0ICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gVGhh -bmtzIGZvciB5b3VyIG1lbnRpb25pbmcsIHRoZW4gSSBjYW4gZmluZCB0aGUgZm9sbG93aW5nIGNv -bW1lbnQgaW4NCj4gc3JwX3F1ZXVlY29tbWFuZCgpOg0KPiANCj4gCQkvKg0KPiAJCSAqIFRoZSBT -Q1NJIEVIIHRocmVhZCBpcyB0aGUgb25seSBjb250ZXh0IGZyb20gd2hpY2ggc3JwX3F1ZXVlY29t -bWFuZCgpDQo+IAkJICogY2FuIGdldCBpbnZva2VkIGZvciBibG9ja2VkIGRldmljZXMgKFNERVZf -QkxPQ0sgLw0KPiAJCSAqIFNERVZfQ1JFQVRFRF9CTE9DSykuIEF2b2lkIHJhY2luZyB3aXRoIHNy -cF9yZWNvbm5lY3RfcnBvcnQoKSBieQ0KPiAJCSAqIGxvY2tpbmcgdGhlIHJwb3J0IG11dGV4IGlm -IGludm9rZWQgZnJvbSBpbnNpZGUgdGhlIFNDU0kgRUguDQo+IAkJICovDQo+IA0KPiBUaGF0IG1l -YW5zIEVIIHJlcXVlc3QgaXMgYWxsb3dlZCB0byBzZW5kIHRvIGJsb2NrZWQgZGV2aWNlLg0KDQpO -byB3YXkuIFRoYXQncyBhIGJ1ZyBhbmQgYSBidWcgdGhhdCBuZWVkcyB0byBiZSBmaXhlZC4NCg0K -QmFydC4= +On Sat, 2018-01-13 at 23:54 +0800, Ming Lei wrote: +> Thanks for your mentioning, then I can find the following comment in +> srp_queuecommand(): +> +> /* +> * The SCSI EH thread is the only context from which srp_queuecommand() +> * can get invoked for blocked devices (SDEV_BLOCK / +> * SDEV_CREATED_BLOCK). Avoid racing with srp_reconnect_rport() by +> * locking the rport mutex if invoked from inside the SCSI EH. +> */ +> +> That means EH request is allowed to send to blocked device. + +No way. That's a bug and a bug that needs to be fixed. + +Bart. diff --git a/a/content_digest b/N1/content_digest index 4d2afc4..071c00f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -19,16 +19,21 @@ " dledford@redhat.com <dledford@redhat.com>\0" "\00:1\0" "b\0" - "T24gU2F0LCAyMDE4LTAxLTEzIGF0IDIzOjU0ICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gVGhh\n" - "bmtzIGZvciB5b3VyIG1lbnRpb25pbmcsIHRoZW4gSSBjYW4gZmluZCB0aGUgZm9sbG93aW5nIGNv\n" - "bW1lbnQgaW4NCj4gc3JwX3F1ZXVlY29tbWFuZCgpOg0KPiANCj4gCQkvKg0KPiAJCSAqIFRoZSBT\n" - "Q1NJIEVIIHRocmVhZCBpcyB0aGUgb25seSBjb250ZXh0IGZyb20gd2hpY2ggc3JwX3F1ZXVlY29t\n" - "bWFuZCgpDQo+IAkJICogY2FuIGdldCBpbnZva2VkIGZvciBibG9ja2VkIGRldmljZXMgKFNERVZf\n" - "QkxPQ0sgLw0KPiAJCSAqIFNERVZfQ1JFQVRFRF9CTE9DSykuIEF2b2lkIHJhY2luZyB3aXRoIHNy\n" - "cF9yZWNvbm5lY3RfcnBvcnQoKSBieQ0KPiAJCSAqIGxvY2tpbmcgdGhlIHJwb3J0IG11dGV4IGlm\n" - "IGludm9rZWQgZnJvbSBpbnNpZGUgdGhlIFNDU0kgRUguDQo+IAkJICovDQo+IA0KPiBUaGF0IG1l\n" - "YW5zIEVIIHJlcXVlc3QgaXMgYWxsb3dlZCB0byBzZW5kIHRvIGJsb2NrZWQgZGV2aWNlLg0KDQpO\n" - "byB3YXkuIFRoYXQncyBhIGJ1ZyBhbmQgYSBidWcgdGhhdCBuZWVkcyB0byBiZSBmaXhlZC4NCg0K\n" - QmFydC4= + "On Sat, 2018-01-13 at 23:54 +0800, Ming Lei wrote:\n" + "> Thanks for your mentioning, then I can find the following comment in\n" + "> srp_queuecommand():\n" + "> \n" + "> \t\t/*\n" + "> \t\t * The SCSI EH thread is the only context from which srp_queuecommand()\n" + "> \t\t * can get invoked for blocked devices (SDEV_BLOCK /\n" + "> \t\t * SDEV_CREATED_BLOCK). Avoid racing with srp_reconnect_rport() by\n" + "> \t\t * locking the rport mutex if invoked from inside the SCSI EH.\n" + "> \t\t */\n" + "> \n" + "> That means EH request is allowed to send to blocked device.\n" + "\n" + "No way. That's a bug and a bug that needs to be fixed.\n" + "\n" + Bart. -1f3330e706ff496f4741306120e5b2608c32fcbbe60dcff4bef9fdc232bb83ca +6d52a96982e1b94c2be8fe6f0223211304aa1ce6fd8bb7f0117de4124e26863b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.