From: Paolo Abeni <pabeni@redhat.com>
To: Wei Wang <weiwan@google.com>, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: Eric Dumazet <edumazet@google.com>, Martin KaFai Lau <kafai@fb.com>
Subject: Re: [PATCH net] ipv6: change route cache aging logic
Date: Sat, 27 Jan 2018 10:39:44 +0100 [thread overview]
Message-ID: <1517045984.3170.1.camel@redhat.com> (raw)
In-Reply-To: <20180126194017.48018-1-tracywwnj@gmail.com>
On Fri, 2018-01-26 at 11:40 -0800, Wei Wang wrote:
> From: Wei Wang <weiwan@google.com>
>
> In current route cache aging logic, if a route has both RTF_EXPIRE and
> RTF_GATEWAY set, the route will only be removed if the neighbor cache
> has no RTN_ROUTE flag. Otherwise, even if the route has expired, it
> won't get deleted.
> Fix this logic to always check if the route has expired first and then
> do the gateway neighbor cache check if previous check decide to not
> remove the exception entry.
>
> Fixes: 1859bac04fb6 ("ipv6: remove from fib tree aged out RTF_CACHE dst")
> Signed-off-by: Wei Wang <weiwan@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Thank you for the fix!
LGTM
Acked-by: Paolo Abeni <pabeni@redhat.com>
Cheers,
/P
next prev parent reply other threads:[~2018-01-27 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 19:40 [PATCH net] ipv6: change route cache aging logic Wei Wang
2018-01-26 20:05 ` Martin KaFai Lau
2018-01-26 20:31 ` Wei Wang
2018-01-27 9:39 ` Paolo Abeni [this message]
2018-01-29 19:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517045984.3170.1.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.