diff for duplicates of <1517200053.21191.1.camel@realtek.com> diff --git a/a/1.txt b/N1/1.txt index 19f3d43..1143a3f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,24 +1,40 @@ -T24gRnJpLCAyMDE4LTAxLTI2IGF0IDEzOjUyICswMDAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG -cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPsKgDQo+IFRo -ZSBpbml0aWFsaXphdGlvbiBvZiBjZmdfY21kIGlzIHJlZHVuZGFudCBhcyB0aGUgdmFsdWUgaXMg -bmV2ZXIgcmVhZA0KPiBhbmQgaXQgaXMgYmVpbmcgcmUtYXNzaWduZWQgdG8gY2ZnX2NtZCA9IHB3 -cmNmZ2NtZFthcnlfaWR4XSBpbnNpZGUgYQ0KPiBsb29wLCBoZW5jZSBpdCBjYW4gYmUgcmVtb3Zl -ZC4NCj7CoA0KPiBDbGVhbnMgdXAgY2xhbmcgd2FybmluZzoNCj4gZHJpdmVycy9zdGFnaW5nL3J0 -bHdpZmkvY29yZS5jOjE4MTk6MjI6IHdhcm5pbmc6IFZhbHVlIHN0b3JlZCB0bw0KPiAnY2ZnX2Nt -ZCcgZHVyaW5nIGl0cyBpbml0aWFsaXphdGlvbiBpcyBuZXZlciByZWFkDQo+wqANCj4gU2lnbmVk -LW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCg0KSXQg -bG9va3MgZ29vZCB0byBtZS4NCg0KQWNrZWQtYnk6IFBpbmctS2UgU2hpaCA8cGtzaGloQHJlYWx0 -ZWsuY29tPg0KDQo+IC0tLQ0KPsKgwqBkcml2ZXJzL3N0YWdpbmcvcnRsd2lmaS9jb3JlLmMgfCAy -ICstDQo+wqDCoDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0K -PsKgDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvcnRsd2lmaS9jb3JlLmMgYi9kcml2 -ZXJzL3N0YWdpbmcvcnRsd2lmaS9jb3JlLmMNCj4gaW5kZXggYTQzZDM3NDUyZThiLi4zZWMwMzk0 -OTgyMDggMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy9ydGx3aWZpL2NvcmUuYw0KPiAr -KysgYi9kcml2ZXJzL3N0YWdpbmcvcnRsd2lmaS9jb3JlLmMNCj4gQEAgLTE4MTYsNyArMTgxNiw3 -IEBAIGJvb2wgcnRsX2hhbF9wd3JzZXFjbWRwYXJzaW5nKHN0cnVjdCBydGxfcHJpdiAqcnRscHJp -diwNCj4gdTggY3V0X3ZlcnNpb24sDQo+wqDCoAkJCcKgwqDCoMKgwqDCoHU4IGZhdmVyc2lvbiwg -dTggaW50ZXJmYWNlX3R5cGUsDQo+wqDCoAkJCcKgwqDCoMKgwqDCoHN0cnVjdCB3bGFuX3B3cl9j -ZmcgcHdyY2ZnY21kW10pDQo+wqDCoHsNCj4gLQlzdHJ1Y3Qgd2xhbl9wd3JfY2ZnIGNmZ19jbWQg -PSB7MH07DQo+ICsJc3RydWN0IHdsYW5fcHdyX2NmZyBjZmdfY21kOw0KPsKgwqAJYm9vbCBwb2xs -aW5nX2JpdCA9IGZhbHNlOw0KPsKgwqAJdTMyIGFyeV9pZHggPSAwOw0KPsKgwqAJdTggdmFsdWUg -PSAwOw0KPiAtLcKgDQo+IDIuMTUuMQ0KPsKgDQo+wqANCj4gLS0tLS0tUGxlYXNlIGNvbnNpZGVy -IHRoZSBlbnZpcm9ubWVudCBiZWZvcmUgcHJpbnRpbmcgdGhpcyBlLW1haWwu +On Fri, 2018-01-26 at 13:52 +0000, Colin King wrote: +> From: Colin Ian King <colin.king@canonical.com> +> +> The initialization of cfg_cmd is redundant as the value is never read +> and it is being re-assigned to cfg_cmd = pwrcfgcmd[ary_idx] inside a +> loop, hence it can be removed. +> +> Cleans up clang warning: +> drivers/staging/rtlwifi/core.c:1819:22: warning: Value stored to +> 'cfg_cmd' during its initialization is never read +> +> Signed-off-by: Colin Ian King <colin.king@canonical.com> + +It looks good to me. + +Acked-by: Ping-Ke Shih <pkshih@realtek.com> + +> --- +> drivers/staging/rtlwifi/core.c | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c +> index a43d37452e8b..3ec039498208 100644 +> --- a/drivers/staging/rtlwifi/core.c +> +++ b/drivers/staging/rtlwifi/core.c +> @@ -1816,7 +1816,7 @@ bool rtl_hal_pwrseqcmdparsing(struct rtl_priv *rtlpriv, +> u8 cut_version, +> u8 faversion, u8 interface_type, +> struct wlan_pwr_cfg pwrcfgcmd[]) +> { +> - struct wlan_pwr_cfg cfg_cmd = {0}; +> + struct wlan_pwr_cfg cfg_cmd; +> bool polling_bit = false; +> u32 ary_idx = 0; +> u8 value = 0; +> -- +> 2.15.1 +> +> +> ------Please consider the environment before printing this e-mail. diff --git a/a/content_digest b/N1/content_digest index d2fb673..2c3a710 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -9,29 +9,45 @@ " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gRnJpLCAyMDE4LTAxLTI2IGF0IDEzOjUyICswMDAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG\n" - "cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPsKgDQo+IFRo\n" - "ZSBpbml0aWFsaXphdGlvbiBvZiBjZmdfY21kIGlzIHJlZHVuZGFudCBhcyB0aGUgdmFsdWUgaXMg\n" - "bmV2ZXIgcmVhZA0KPiBhbmQgaXQgaXMgYmVpbmcgcmUtYXNzaWduZWQgdG8gY2ZnX2NtZCA9IHB3\n" - "cmNmZ2NtZFthcnlfaWR4XSBpbnNpZGUgYQ0KPiBsb29wLCBoZW5jZSBpdCBjYW4gYmUgcmVtb3Zl\n" - "ZC4NCj7CoA0KPiBDbGVhbnMgdXAgY2xhbmcgd2FybmluZzoNCj4gZHJpdmVycy9zdGFnaW5nL3J0\n" - "bHdpZmkvY29yZS5jOjE4MTk6MjI6IHdhcm5pbmc6IFZhbHVlIHN0b3JlZCB0bw0KPiAnY2ZnX2Nt\n" - "ZCcgZHVyaW5nIGl0cyBpbml0aWFsaXphdGlvbiBpcyBuZXZlciByZWFkDQo+wqANCj4gU2lnbmVk\n" - "LW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCg0KSXQg\n" - "bG9va3MgZ29vZCB0byBtZS4NCg0KQWNrZWQtYnk6IFBpbmctS2UgU2hpaCA8cGtzaGloQHJlYWx0\n" - "ZWsuY29tPg0KDQo+IC0tLQ0KPsKgwqBkcml2ZXJzL3N0YWdpbmcvcnRsd2lmaS9jb3JlLmMgfCAy\n" - "ICstDQo+wqDCoDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0K\n" - "PsKgDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvcnRsd2lmaS9jb3JlLmMgYi9kcml2\n" - "ZXJzL3N0YWdpbmcvcnRsd2lmaS9jb3JlLmMNCj4gaW5kZXggYTQzZDM3NDUyZThiLi4zZWMwMzk0\n" - "OTgyMDggMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy9ydGx3aWZpL2NvcmUuYw0KPiAr\n" - "KysgYi9kcml2ZXJzL3N0YWdpbmcvcnRsd2lmaS9jb3JlLmMNCj4gQEAgLTE4MTYsNyArMTgxNiw3\n" - "IEBAIGJvb2wgcnRsX2hhbF9wd3JzZXFjbWRwYXJzaW5nKHN0cnVjdCBydGxfcHJpdiAqcnRscHJp\n" - "diwNCj4gdTggY3V0X3ZlcnNpb24sDQo+wqDCoAkJCcKgwqDCoMKgwqDCoHU4IGZhdmVyc2lvbiwg\n" - "dTggaW50ZXJmYWNlX3R5cGUsDQo+wqDCoAkJCcKgwqDCoMKgwqDCoHN0cnVjdCB3bGFuX3B3cl9j\n" - "ZmcgcHdyY2ZnY21kW10pDQo+wqDCoHsNCj4gLQlzdHJ1Y3Qgd2xhbl9wd3JfY2ZnIGNmZ19jbWQg\n" - "PSB7MH07DQo+ICsJc3RydWN0IHdsYW5fcHdyX2NmZyBjZmdfY21kOw0KPsKgwqAJYm9vbCBwb2xs\n" - "aW5nX2JpdCA9IGZhbHNlOw0KPsKgwqAJdTMyIGFyeV9pZHggPSAwOw0KPsKgwqAJdTggdmFsdWUg\n" - "PSAwOw0KPiAtLcKgDQo+IDIuMTUuMQ0KPsKgDQo+wqANCj4gLS0tLS0tUGxlYXNlIGNvbnNpZGVy\n" - IHRoZSBlbnZpcm9ubWVudCBiZWZvcmUgcHJpbnRpbmcgdGhpcyBlLW1haWwu + "On Fri, 2018-01-26 at 13:52 +0000, Colin King wrote:\n" + "> From: Colin Ian King <colin.king@canonical.com>\n" + ">\302\240\n" + "> The initialization of cfg_cmd is redundant as the value is never read\n" + "> and it is being re-assigned to cfg_cmd = pwrcfgcmd[ary_idx] inside a\n" + "> loop, hence it can be removed.\n" + ">\302\240\n" + "> Cleans up clang warning:\n" + "> drivers/staging/rtlwifi/core.c:1819:22: warning: Value stored to\n" + "> 'cfg_cmd' during its initialization is never read\n" + ">\302\240\n" + "> Signed-off-by: Colin Ian King <colin.king@canonical.com>\n" + "\n" + "It looks good to me.\n" + "\n" + "Acked-by: Ping-Ke Shih <pkshih@realtek.com>\n" + "\n" + "> ---\n" + ">\302\240\302\240drivers/staging/rtlwifi/core.c | 2 +-\n" + ">\302\240\302\2401 file changed, 1 insertion(+), 1 deletion(-)\n" + ">\302\240\n" + "> diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c\n" + "> index a43d37452e8b..3ec039498208 100644\n" + "> --- a/drivers/staging/rtlwifi/core.c\n" + "> +++ b/drivers/staging/rtlwifi/core.c\n" + "> @@ -1816,7 +1816,7 @@ bool rtl_hal_pwrseqcmdparsing(struct rtl_priv *rtlpriv,\n" + "> u8 cut_version,\n" + ">\302\240\302\240\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240u8 faversion, u8 interface_type,\n" + ">\302\240\302\240\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240struct wlan_pwr_cfg pwrcfgcmd[])\n" + ">\302\240\302\240{\n" + "> -\tstruct wlan_pwr_cfg cfg_cmd = {0};\n" + "> +\tstruct wlan_pwr_cfg cfg_cmd;\n" + ">\302\240\302\240\tbool polling_bit = false;\n" + ">\302\240\302\240\tu32 ary_idx = 0;\n" + ">\302\240\302\240\tu8 value = 0;\n" + "> --\302\240\n" + "> 2.15.1\n" + ">\302\240\n" + ">\302\240\n" + > ------Please consider the environment before printing this e-mail. -1788393c5320c1e4207421e81e89d097fb226ba6132670ca7608101d1f2b2606 +f7631185944accd2f90985d25c21fdb8b960ad78f5ea0bd6f7b34aa554a8e81b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.