From: "Kalamarz, Lukasz" <lukasz.kalamarz@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Subject: Re: [igt-dev] [PATCH i-g-t] gem_gpu_fill: Merging gem_gpgpu_fill and gem_media_fill into one
Date: Mon, 29 Jan 2018 12:18:27 +0000 [thread overview]
Message-ID: <1517228306.3558.1.camel@intel.com> (raw)
In-Reply-To: <151697967468.674.10136288566334785019@mail.alporthouse.com>
On Fri, 2018-01-26 at 15:14 +0000, Chris Wilson wrote:
> Quoting Lukasz Kalamarz (2018-01-26 15:03:02)
> > Implementation of those test only differ with fill_function used by
> > either media or gpgpu pipeline, which shared same type. Rather than
> > having two tests, which are in 98% copy-paste it is easier to
> > maintain one with same functionality.
>
> I hear there's a render equivalent as well.
> I presume each routine is run over all engines that support it?
There is similar test (gem_render_copy) with slightly different
semantics and it is using other struct to perform operation
(igt_fillfunc_t vs igt_copy_function_t).
We can implement render_fill_func using render blit. Is that what You
have in mind?
Each routine is run over all engines (meaning the only engine that
supports it - render).
-Lukasz
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-01-29 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 15:03 [igt-dev] [PATCH i-g-t] gem_gpu_fill: Merging gem_gpgpu_fill and gem_media_fill into one Lukasz Kalamarz
2018-01-26 15:14 ` Chris Wilson
2018-01-29 12:18 ` Kalamarz, Lukasz [this message]
2018-01-29 12:52 ` Chris Wilson
2018-01-26 15:20 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-01-26 16:10 ` [igt-dev] ✗ Fi.CI.IGT: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517228306.3558.1.camel@intel.com \
--to=lukasz.kalamarz@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.