From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] pci: fix one device probing
Date: Fri, 16 Sep 2016 15:20:04 +0200
Message-ID: <1517241.brkdynD5ST@xps13>
References: <1470311406-38841-1-git-send-email-iryzhov@nfware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Igor Ryzhov <iryzhov@nfware.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 4B08E6CC1
 for <dev@dpdk.org>; Fri, 16 Sep 2016 15:20:07 +0200 (CEST)
Received: by mail-wm0-f48.google.com with SMTP id b187so36905162wme.1
 for <dev@dpdk.org>; Fri, 16 Sep 2016 06:20:07 -0700 (PDT)
In-Reply-To: <1470311406-38841-1-git-send-email-iryzhov@nfware.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-08-04 14:50, Igor Ryzhov:
> The rte_eal_pci_probe_one function could return false positive result if
> no driver is found for the device.
> 
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
[...]
> --- a/lib/librte_eal/common/eal_common_pci.c
> +++ b/lib/librte_eal/common/eal_common_pci.c
> @@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr)
>  			continue;
>  
>  		ret = pci_probe_all_drivers(dev);
> -		if (ret < 0)
> +		if (ret)
>  			goto err_return;
>  		return 0;
>  	}

This patch was discussed in another thread:
	http://dpdk.org/ml/archives/dev/2016-August/045127.html
Is there anyone thinking this patch is not a step forward?